From owner-freebsd-current@FreeBSD.ORG  Mon Oct 27 18:00:35 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7C2A7106566B;
	Mon, 27 Oct 2008 18:00:35 +0000 (UTC)
	(envelope-from Hartmut.Brandt@dlr.de)
Received: from smtp-3.dlr.de (smtp-3.dlr.de [195.37.61.187])
	by mx1.freebsd.org (Postfix) with ESMTP id 09DF58FC20;
	Mon, 27 Oct 2008 18:00:34 +0000 (UTC)
	(envelope-from Hartmut.Brandt@dlr.de)
Received: from [129.247.12.5] ([129.247.12.5]) by smtp-3.dlr.de with Microsoft
	SMTPSVC(6.0.3790.1830); Mon, 27 Oct 2008 18:47:16 +0100
Message-ID: <4905FE95.9030405@dlr.de>
Date: Mon, 27 Oct 2008 18:47:01 +0100
From: Hartmut Brandt <hartmut.brandt@dlr.de>
User-Agent: Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version: 1.0
To: Diomidis Spinellis <dds@aueb.gr>
References: <20080528110003.Q24259@beagle.kn.op.dlr.de>
	<483D5DF8.4020504@icyb.net.ua> <483F1559.2020600@aueb.gr>
	<4905DD47.7040107@aueb.gr>
In-Reply-To: <4905DD47.7040107@aueb.gr>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-OriginalArrivalTime: 27 Oct 2008 17:47:16.0271 (UTC)
	FILETIME=[0CFB43F0:01C9385C]
Cc: Harti Brandt <harti@FreeBSD.ORG>, Andriy Gapon <avg@icyb.net.ua>,
	current@FreeBSD.ORG
Subject: Re: cp(1) and mmap
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Oct 2008 18:00:35 -0000

Diomidis Spinellis wrote:
> Diomidis Spinellis wrote:
>> Andriy Gapon wrote:
>>> on 28/05/2008 12:02 Harti Brandt said the following:
>>>> Hi all,
>>>>
>>>> it looks like there is no fallback in cp(1) when mmaping the source 
>>>> file
>>>> fails. I'm mounting SMB shares via smbnetfs (which in turn uses fuse)
>>>> and it seems not to support mmaping files. Shouldn't cp just 
>>>> fallback to
>>>> a normal read()/write() loop in this case?
>>>
>>> I would think that it should.
>>> This topic was brought up several times, but no resolution so far.
>>> I think that I've even seen patches.
>>>
>>
>> I've not seen the patches, but the fix is trivial (see the attached 
>> patch).  If there are no objections, I can commit it.
>
> Fix committed in 184342.  Sorry for the long delay.
>
No problem. Thanks. I had this still in my inbox and was several times 
about to commit it, but was distracted each time. Thanks, this helps alot.

harti
> - dds
>