From owner-svn-ports-all@FreeBSD.ORG Mon Sep 15 16:29:56 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E36FEFD5; Mon, 15 Sep 2014 16:29:55 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B6C2CBCF; Mon, 15 Sep 2014 16:29:55 +0000 (UTC) Received: from [192.168.192.25] (dhcp-108-170-169-12.cable.user.start.ca [108.170.169.12]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by apnoea.adamw.org (Postfix) with ESMTPSA id 4399C114007; Mon, 15 Sep 2014 12:29:52 -0400 (EDT) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: svn commit: r368241 - in head/sysutils: . jadm jadm/files From: Adam Weinberger In-Reply-To: Date: Mon, 15 Sep 2014 12:29:50 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: <3A4A31F5-EADB-4B23-97D4-15368CCC9752@adamw.org> References: <201409150227.s8F2ReuH083121@svn.freebsd.org> <539C903B-6DBA-42E3-8B99-76E3A92987A0@adamw.org> To: "Jason E. Hale" X-Mailer: Apple Mail (2.1878.6) Cc: "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , ports-committers , jadm , "Vanilla I. Shu" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Sep 2014 16:29:56 -0000 On 15 Sep, 2014, at 12:05, Jason E. Hale wrote: > On Mon, Sep 15, 2014 at 10:36 AM, Adam Weinberger = wrote: >> On 15 Sep, 2014, at 3:50, Jason E. Hale wrote: >>=20 >>> On Sun, Sep 14, 2014 at 10:27 PM, Vanilla I. Shu = wrote: >>>>=20 >>>> +BUILD_DEPENDS=3D = ${PYTHON_LIBDIR}/site-packages/paramiko/:${PORTSDIR}/security/py-paramiko = \ >>>> + = ${PYTHON_LIBDIR}/site-packages/netifaces.so:${PORTSDIR}/net/py-netifaces = \ >>>> + = ${PYTHON_LIBDIR}/site-packages/tabulate.py:${PORTSDIR}/devel/py-tabulate = \ >>>> + = ${PYTHON_LIBDIR}/site-packages/ipaddress.py:${PORTSDIR}/net/py-ipaddress >>>=20 >>> This is a deprecated style of depending on other Python ports. >>> Format should be: >>> BUILD_DEPENDS=3D = ${PYTHON_PKGNAMEPREFIX}paramiko>=3D0:${PORTSDIR}/security/py-paramiko >>=20 >> I had no idea that format was deprecated. Perhaps an example could be = added to the PHB or Uses/python.mk? >>=20 > I'm sure the Python section of the PHB could use some attention. It > still references the old USE_PYTHON and > bsd.python.mk instead of USES=3Dpython and Uses/python.mk among other = things. >=20 > The format I mentioned is the one I have seen in most Python and Perl > ports, however, Uses/python.mk has a mix > of both styles. I guess "deprecated" was a little strong, that's more > of an official word. "Not so common" might be > more appropriate. To me, it looks cleaner and allows for version > checking. Even still, ${PYTHON_SITELIBDIR} > would be preferable to ${PYTHON_LIBDIR}/site-packages. No I totally agree with you. It=92d just be really nice if you could = count on the PHB being full of examples of best-practice. The funny thing is, each thing that you mentioned in your original = message to Vanilla (LICENSE_FILE, PYTHON_PKGNAMEPREFIX, OPSYS, and not = using ${CP})... none of those things are spelled out in the PHB. I would think that the vast majority of the PHB should be like Section = 6... a big list of =93Using xyz=94. Alphabetize it, and every time = somebody wants to know how to do x, they just jump to that section. = Right now, there is essentially no structure. I especially love that the sample Makefile demonstrates an interactive = port, clobbers variables, uses sets EXTRACT_SUFX manually, and contains = more filler text than code. The sample makefile should be = self-documenting, and should be a proper set of real-world uses that = people can look at as a positive reference. # Adam --=20 Adam Weinberger adamw@adamw.org http://www.adamw.org