From nobody Thu Apr 6 13:19:55 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Pshtl4p8bz44LQs; Thu, 6 Apr 2023 13:19:59 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Pshtl3585z47qx; Thu, 6 Apr 2023 13:19:59 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680787199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PCOQWlU/33wYeJDf1s/rTjm4rONzlo2boXOoVM3jgoc=; b=J1BULbRHY7CXZkkS6DIcB9hruM7R9rDXeANNxUuj7UdJ5D5Z/WinEcuSE8tRsm9B6Q4gt1 +AR2w3e4DSJTtKM9bFMmNFYYTzGLUye8Y6uuy3MvBwXGz93yCEg0IFeJSNu/A1x08UksCN j2dZaVmm9oSgYCyCSmse/1ysOdInz8HSszOHxCvZCXaSXxYZXV5xTfsHvDgIm0hmnf9rwz SEmP5wVY1b0//yRXlZuQZu4DnN4YPblRE5lHlY/bCYm0jbGZS4JSAqyAGDOCtGqeDM56KO tbwdqqlQy2h6y0yYUC0Vl9ZacZkev0h8voGJb7vj6RY7k8YmMpb0udf4mGbpSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680787199; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PCOQWlU/33wYeJDf1s/rTjm4rONzlo2boXOoVM3jgoc=; b=huhmDkAsCWcm1YPExqurHm0zJiUoAz6PiwZ5UR2XQ2OkeIObtvSFQSDHkFv4ZDjjL5io3i 5A08CFaKhiIXAqYSchn7jTly6Fz9+EsQOsHYCCW/VLTq3PjTai3OiE696w2+W1oKUhrx/g cLuhybPwJ7NCDFRiUrLZRfojfW2qXA698Ur5PCO1YCJjN4WfqSHY/PkoJxkDNsH2VsFUXr Q726en8R+XWQ+JU1Zy8Xa3CT/bMqT3Wd6OpflTatOYr66jBF07T7xYw5tGsYLpfC2mVItp HF846lGCisweuU8rJH67VlCZXM9zwi+Kh5cXKpRvmb/Trx4e/5SDhOmHpgZKfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680787199; a=rsa-sha256; cv=none; b=vuXwLXj3N2R2GP5reQtstjxNZyZRpkNwzPis2q9CFM3cY5Jgksvq6NDfl9NYCER7DAzvTQ kOV1mpmw91eyKjyt4kAFi3sI30/UC1cxj7n4HfD/kYAl890MtSG0T9ttp9bd/Ow9n7V86T VYveU5MYHWiywMti/OBLolzF+iR+hKfiGTcczc85VNuqi8UIuKTs3omwA5uUNXlvoxLn08 iL4jl249BUeh1R3vBBJtJjL5zyu3DGWwc0DP9fmd9lTN7DJeWbjQQN4NgThrHrhT/DYCIe qEQFgyD160l6+eT9cUvHvO/lN7LZs4oruScGftD2QDW7lNqZC8qclT4Q8urJFg== Received: from [172.24.42.13] (host-79-32-120-162.retail.telecomitalia.it [79.32.120.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Pshtk28WKzbt3; Thu, 6 Apr 2023 13:19:58 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Message-ID: Date: Thu, 6 Apr 2023 15:19:55 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: git: 72ad532057c9 - main - archivers/zstd: Add CMake config files and adjust Makefile To: Alexey Dokuchaev Cc: Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202304050615.3356FKNq062154@gitrepo.freebsd.org> <7accd096-7871-29ad-0824-c035504d01b0@FreeBSD.org> Content-Language: en-US From: Guido Falsi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ThisMailContainsUnwantedMimeParts: N On 06/04/23 15:17, Alexey Dokuchaev wrote: > On Wed, Apr 05, 2023 at 02:20:21PM +0200, Guido Falsi wrote: >> On 05/04/23 08:15, Daniel Engberg wrote: >>> commit 72ad532057c9f9fb6fa370c80f663c005e9dd021 >>> >>> archivers/zstd: Add CMake config files and adjust Makefile >>> >>> - Use upstream's short test for "make test" >>> - Use verbose output by default during build >>> * Tweak Makefile to follow Porters Handbook more closely >>> * Install CMake files (taken from CMake build framework) >>> >>> PR: 267652 >>> Reported by: fluffy >>> Approved by: portmgr (maintainer timeout, 1+ month) >> >> Looks like this, un[luckily], causes a failure with devel/qt6-base >> (abridged error, full log if needed): >> >> ld: error: relocation R_X86_64_32 cannot be used against local symbol; >> recompile with -fPIC >> >>> defined in /usr/local/lib/libzstd.a(zstd_common.o) >> >>> referenced by zstd_common.c >> >>> zstd_common.o:(ZSTD_versionString) in archive > > Yeah, I'm seeing this as well. Admittedly, the whole commit looks > dubious to me, with all these out-of-blue new files and gratuitous > changes. I guess sunpoet@ should revert it and merge only needed > parts thereof properly. > I have only reported the issue as an early warning, as I said. Regarding qt6-base a fix has already been proposed here by diizzy: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270664 Once committed should solve the issue for all, I'm testing it and it looks fine. -- Guido Falsi