From owner-svn-src-head@freebsd.org Wed Dec 9 02:19:05 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4FE759D5557; Wed, 9 Dec 2015 02:19:05 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from mail.mahoroba.org (ent.mahoroba.org [IPv6:2001:2f0:104:8010::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "asuka.mahoroba.org", Issuer "ca.mahoroba.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id F2D371B2A; Wed, 9 Dec 2015 02:19:04 +0000 (UTC) (envelope-from ume@mahoroba.org) Received: from asuka.mahoroba.org (ume@ent.mahoroba.org [IPv6:2001:2f0:104:8010::1]) (user=ume mech=CRAM-MD5 bits=0) by mail.mahoroba.org (8.15.2/8.15.2) with ESMTPSA/inet6 id tB92IsYI033379 (version=TLSv1.2 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 9 Dec 2015 11:18:58 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Wed, 09 Dec 2015 11:18:54 +0900 Message-ID: From: Hajimu UMEMOTO To: Eric van Gyzen Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291994 - head/include In-Reply-To: <201512081609.tB8G9mfd053070@repo.freebsd.org> References: <201512081609.tB8G9mfd053070@repo.freebsd.org> User-Agent: xcite1.60> Wanderlust/2.15.9 (Almost Unreal) Emacs/24.5 Mule/6.0 (HANACHIRUSATO) X-Operating-System: FreeBSD 10.2-STABLE X-PGP-Key: http://www.mahoroba.org/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.mahoroba.org [IPv6:2001:2f0:104:8010::1]); Wed, 09 Dec 2015 11:18:58 +0900 (JST) X-Virus-Scanned: clamav-milter 0.98.7 at asuka.mahoroba.org X-Virus-Status: Clean X-Spam-Status: No, score=-3.5 required=5.0 tests=ALL_TRUSTED,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on asuka.mahoroba.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Dec 2015 02:19:05 -0000 Hi, >>>>> On Tue, 8 Dec 2015 16:09:48 +0000 (UTC) >>>>> Eric van Gyzen said: vangyzen> Author: vangyzen vangyzen> Date: Tue Dec 8 16:09:48 2015 vangyzen> New Revision: 291994 vangyzen> URL: https://svnweb.freebsd.org/changeset/base/291994 vangyzen> Log: vangyzen> resolver: fix the build of some ports, broken by r289315 vangyzen> vangyzen> r289315 required time_t and struct timespec to be defined before vangyzen> including . This broke the build of net-mgmt/sx, at least. vangyzen> vangyzen> Include in resolv.h to fix this with minimal pollution. vangyzen> vangyzen> Reported by: Raphael Kubo da Costa vangyzen> MFC after: 3 days vangyzen> Sponsored by: Dell Inc. It seems wrong. We should not have pollution from timespec.h, here. You should consider moving them into __res_state_ext like NetBSD does. Sincerely, -- Hajimu UMEMOTO ume@mahoroba.org ume@FreeBSD.org http://www.mahoroba.org/~ume/