From owner-freebsd-emulation@FreeBSD.ORG  Thu Sep 25 20:40:59 2008
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
Delivered-To: freebsd-emulation@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A45721065686
	for <freebsd-emulation@freebsd.org>;
	Thu, 25 Sep 2008 20:40:59 +0000 (UTC)
	(envelope-from anthony@codemonkey.ws)
Received: from wr-out-0506.google.com (wr-out-0506.google.com [64.233.184.234])
	by mx1.freebsd.org (Postfix) with ESMTP id 60AD68FC20
	for <freebsd-emulation@freebsd.org>;
	Thu, 25 Sep 2008 20:40:59 +0000 (UTC)
	(envelope-from anthony@codemonkey.ws)
Received: by wr-out-0506.google.com with SMTP id c8so114728wra.27
	for <freebsd-emulation@freebsd.org>;
	Thu, 25 Sep 2008 13:40:58 -0700 (PDT)
Received: by 10.100.41.9 with SMTP id o9mr306715ano.84.1222375258306;
	Thu, 25 Sep 2008 13:40:58 -0700 (PDT)
Received: from squirrel.codemonkey.ws ( [32.97.110.142])
	by mx.google.com with ESMTPS id d24sm1731014and.24.2008.09.25.13.40.56
	(version=TLSv1/SSLv3 cipher=RC4-MD5);
	Thu, 25 Sep 2008 13:40:57 -0700 (PDT)
Message-ID: <48DBF71E.1000405@codemonkey.ws>
Date: Thu, 25 Sep 2008 15:39:58 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
User-Agent: Thunderbird 2.0.0.16 (X11/20080723)
MIME-Version: 1.0
To: Juergen Lock <nox@jelal.kn-bremen.de>, qemu-devel@nongnu.org, 
	freebsd-emulation@freebsd.org
References: <20080921204025.GA81055@saturn.kn-bremen.de>	<200809242210.m8OMAcSZ021572@saturn.kn-bremen.de>
	<20080925201703.GA12142@saturn.kn-bremen.de>
In-Reply-To: <20080925201703.GA12142@saturn.kn-bremen.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: [Qemu-devel] [PATCH] preprocessor issue in
	qemu/patch-block-raw-posix.c
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Sep 2008 20:40:59 -0000

Juergen Lock wrote:
> I forgot to note that this also needed the following patch:
>   

Why?  This #ifdef is working around a very specific bug.

Regards,

Anthony Liguori

> Index: qemu/block-raw-posix.c
> @@ -545,7 +545,8 @@
>  
>      qemu_aio_set_fd_handler(s->fd, posix_aio_read, NULL, posix_aio_flush, s);
>  
> -#if defined(__linux__) && defined(__GLIBC_PREREQ) && !__GLIBC_PREREQ(2, 4)
> +#if defined(__linux__) && defined(__GLIBC_PREREQ)
> +#if !__GLIBC_PREREQ(2, 4)
>      {
>          /* XXX: aio thread exit seems to hang on RedHat 9 and this init
>             seems to fix the problem. */
> @@ -557,6 +558,7 @@
>          aio_init(&ai);
>      }
>  #endif
> +#endif
>      posix_aio_state = s;
>  
>      return 0;
>
> Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
>
>
>