From nobody Sat Mar 2 07:45:20 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TmxpP4hR7z5CFF5; Sat, 2 Mar 2024 07:45:49 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TmxpP2zpPz48YC; Sat, 2 Mar 2024 07:45:49 +0000 (UTC) (envelope-from 6yearold@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ua1-f44.google.com with SMTP id a1e0cc1a2514c-7d995bd557eso1758581241.0; Fri, 01 Mar 2024 23:45:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709365548; x=1709970348; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/DC4K9K1tbJ8f7gAxOaJy/anv3RJfGXoaAjHolpN2mc=; b=NLuZTH/+EGNVA1QfEdwQXrnHsm9XfgasRsxHZIZwaN9PBiJEE4LPWT9qJEndwOeAT/ Z5UFjWHutZNkOLxl0yfPa5pzIeT4bCEbEBx1hVGODPIDW/2Eau/ccxt5juf6Msi3J8mt 2OdmkrO1rvlzH1eDxb2eqjT2Eb/d4Wf39QGHWyjDEDD6h6Hl35K1igIDYjOaE8ODaGKC zK5iMSCwyqT0tVDv0jwlhvMeRVGTEENLufIfjxhgahUN5hLXC3XldTsGel/2/E7NMqMy 2wXXC5jzgHqUcHCV/Yi8TNmmIJXs6wWor4cWgCNVQqSisYOD+6DF3x6EwRPsgZD3HcoL vWkQ== X-Forwarded-Encrypted: i=1; AJvYcCXw0cfrlgot4Uaz53lwFbRpWWZr8hywDWMBvT2t0+gyEb9Vo3N+L6LiXDDHj4DQIsEWDQKSrPxXK1uA7qVqhvU9TJUyHnwROGNOT3SfHGXwy/rOKPsjXvGFCoYmtN5nU4IFRRvy2+oTBBgjAgNtrdmW2lbmgxw= X-Gm-Message-State: AOJu0Yy0Gfh6W4/XefEvGJ+YIIFrgpqJx93bd3TE8f+wQHAwT3SqdLjx NFxKoOEvAI3xuyw4yEZCEvVFMv+MGMqV1lzqPWAxz7bfJ70vk5qV7imL11fvhl0= X-Google-Smtp-Source: AGHT+IG0zkoaBY5G+ApjvsJGq/MMr8qGJ2p0xTZKeAIocyjv/5DUmO/NlBsqiWi38OYj9KRKh7kG5w== X-Received: by 2002:a67:ce86:0:b0:472:6b36:4529 with SMTP id c6-20020a67ce86000000b004726b364529mr3677279vse.27.1709365547937; Fri, 01 Mar 2024 23:45:47 -0800 (PST) Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com. [209.85.222.44]) by smtp.gmail.com with ESMTPSA id g10-20020a056102158a00b0046d35339f2bsm939202vsv.3.2024.03.01.23.45.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Mar 2024 23:45:47 -0800 (PST) Received: by mail-ua1-f44.google.com with SMTP id a1e0cc1a2514c-7d2e19120b5so1649556241.2; Fri, 01 Mar 2024 23:45:47 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXaNvq683aMENFLeeTD0HwR5tM97nH8Q2l07lz8Zx7vBfe8XLxfQpeHcKYweECXADchSbGA6JdZxzJdDQqUUK946y7r3bNVB9vL8wamQltxXAe4FBhXq7oHCgiNMMqFBhRbdZObEAPKT//MgFtWL5Zgae2NkrM= X-Received: by 2002:a67:e403:0:b0:472:7256:e632 with SMTP id d3-20020a67e403000000b004727256e632mr3780266vsf.25.1709365547546; Fri, 01 Mar 2024 23:45:47 -0800 (PST) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 References: <202403011927.421JRqxx065749@gitrepo.freebsd.org> In-Reply-To: From: Gleb Popov Date: Sat, 2 Mar 2024 10:45:20 +0300 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: c2afef5c2587 - main - Features/testing.mk: Introduce the TESTING_UNSAFE knob. To: Daniel Engberg Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4TmxpP2zpPz48YC On Fri, Mar 1, 2024 at 11:20=E2=80=AFPM Daniel Engberg wrote: > > Hi, > > Thanks for adding this, however this won't work on ports that uses TEST m= enu option as far as I can tell which is a relatively common occurence? > > Se also https://cgit.freebsd.org/ports/tree/Mk/bsd.options.desc.mk#n495 > Best regards, > Daniel > There is a subtle overlap between Features and OPTIONS that I still have not fully grasped. A Feature can be thought of as an OPTION that is generic enough to be applied to every port. For instance, almost every software can be built in the "debug" mode (whatever that means), which makes DEBUG a good candidate for a Feature and not an OPTION. However, some software may have additional toggles that are not hooked into the standard way of enabling debug mode for a given build system. A CMake example - there is a standard CMAKE_BUILD_TYPE variable, but the software may also define sort of ENABLE_EXTRA_CHECKS option, which further improve debugging experience but is not enabled by CMAKE_BUILD_TYPE. In such cases it might have a sense to define the DEBUG option and then do DEBUG_CMAKE_ON=3D -DENABLE_EXTRA_CHECKS=3Dyes in the port. In case of LTO a software may require some additional dependency, so that just setting WITH_LTO=3Dyes would not be enough. So this is another case where the option-corresponding-to-a-feature is required. Note that it is still possible to build WITH_DEBUG=3Dyes but WITHOUT=3DDEBUG. It will enable debugging in general, but not enable some specific debugging features for the given port. This hints that Features and OPTIONS are separate ideas and probably should coexist. Getting back to the TESTING feature, I agree that the TEST option doesn't really make sense as it is. At least we should change its description and remove the "and/or run" part, because running tests is now (and should be) a Feature-level decision. Maybe the TEST option doesn't make sense at all now, but like I said I didn't get my head over it yet. Let's see how it goes.