From owner-cvs-all  Mon Mar  3 16:39:28 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 59E8237B401; Mon,  3 Mar 2003 16:39:26 -0800 (PST)
Received: from mail.chesapeake.net (chesapeake.net [205.130.220.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4A5BC43FB1; Mon,  3 Mar 2003 16:39:25 -0800 (PST)
	(envelope-from jroberson@chesapeake.net)
Received: from localhost (jroberson@localhost)
	by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h240dNu05448;
	Mon, 3 Mar 2003 19:39:23 -0500 (EST)
	(envelope-from jroberson@chesapeake.net)
Date: Mon, 3 Mar 2003 19:39:23 -0500 (EST)
From: Jeff Roberson <jroberson@chesapeake.net>
To: Alfred Perlstein <bright@mu.org>
Cc: Jeff Roberson <jeff@FreeBSD.org>, <src-committers@FreeBSD.org>,
	<cvs-src@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/kern vfs_default.c
In-Reply-To: <20030304003400.GG43089@elvis.mu.org>
Message-ID: <20030303193715.N72102-100000@mail.chesapeake.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 3 Mar 2003, Alfred Perlstein wrote:

> >
> >   Modified files:
> >     sys/kern             vfs_default.c
> >   Log:
> >    - Correct the wchan in vop_stdfsync()
> >
> >   This is almost what bde asked for.  There is some desire to have per fs wchans
> >   still but that is difficult giving the current arrangement of the code.
>
> not safe, but the general idea...
>
> char wchanstkbuf[7];
> char *p = wchanstkbuf;
>
> sprintf(p, "%ssync", vp->v_type);
>

Yeah, I was considering something along these lines.  Unfortunately you're
likely to only get 2 characters of the filesystem type if you used "sync"
for the rest.  This yields a potentially more effecient and safe
implementation:

char wchanbuf[7] = "  sync";
wchanbuf[0] = vp->v_type[0];
wchanbuf[1] = vp->v_type[1];

Looks good no?

Maybe I'll check that in.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message