From owner-svn-src-head@freebsd.org Wed May 3 19:34:27 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7178ED58329 for ; Wed, 3 May 2017 19:34:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4192B14C2 for ; Wed, 3 May 2017 19:34:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x231.google.com with SMTP id r16so195898776ioi.2 for ; Wed, 03 May 2017 12:34:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=TFF594BjSX5ipCMoL+BCTMg98HdXZFviA1sY92gfW9k=; b=QhZCUIB8NmmK2Ge5VTZj/EiSHjYYHTXa0Kbf9FhEo7g4NHZxRGhyu/PDHsPpZB9pq/ ZIfbAidwDxtYWZUnnJ0pkZuPMCGXwFzY140bQdw98Jez+wQOW4ugMW5bV43LXQvg2Wno VytFXqQ5HIAOkr71JuivP1yt6Ct9b//5sJqo2J40l0ABxuVPb33kEJ7Qown+1euf2CQj zoUji98dkOKN/2NjnDxH05BoXcxA+gKZCjJMsj0+i9+yy4ywAhrpIW88OF2IFPa+Trbh 4vV2SmNu6lDPCqL3CaFt3roC+sSliCmpjArD70/syXjuOZkeCLMM20r4NRTItykSnvG9 x+NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=TFF594BjSX5ipCMoL+BCTMg98HdXZFviA1sY92gfW9k=; b=PL/nHpkp0L1YCEGQ+o0U1PCdmxv5ku+E4SmPS5FfhAXa6RXEF2J/tH6aV2kPrJJfAr xrVyfusePq1ciLihbUvMo2WqMP3+3UYY+FfRY048AOSuKNGL1oRjRSBYWjL4DkMWDuZ8 wy3hT3m+fBpwScjQOVEVrKQ28O3HqH6cX9JliJWLElDa5bCxwlJrWCdL25mzOXRRUktp axe4agMCgpzI17Tq2Cw7elbIX3p46H7c8NeVEZb19vFyRo4Elc751xghrttcnEmgQLos S7RYaHMVc0hgrxjFlpbYLav5h4AzbG6zLGtI3cPP24NVLVl9dqL5jqT509PH4PEFkAbb uCkQ== X-Gm-Message-State: AN3rC/47C63E+veJZB0hp2/iYcPRNmK491c0gouaRwDpBbFYuyFjY9ou e1EkvjWpyWxsThJrIkoeWOhTaOdYzg== X-Received: by 10.107.8.136 with SMTP id h8mr42151744ioi.134.1493840066324; Wed, 03 May 2017 12:34:26 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.126.6 with HTTP; Wed, 3 May 2017 12:34:25 -0700 (PDT) X-Originating-IP: [2607:fb10:7021:1::44a] In-Reply-To: References: <201705031721.v43HL2vS071819@repo.freebsd.org> <8EA7A2E9-A429-4DC2-85CE-1B5AAEDF86FD@gmail.com> From: Warner Losh Date: Wed, 3 May 2017 13:34:25 -0600 X-Google-Sender-Auth: JuQ9oSIEM3fYj4rYSyH_Fstiw7o Message-ID: Subject: Re: svn commit: r317755 - head/sbin/ifconfig To: Alan Somers Cc: Ngie Cooper , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 19:34:27 -0000 On Wed, May 3, 2017 at 1:32 PM, Alan Somers wrote: > On Wed, May 3, 2017 at 12:16 PM, Ngie Cooper wrote: >> >>> On May 3, 2017, at 10:21, Alan Somers wrote: >>> >>> Author: asomers >>> Date: Wed May 3 17:21:01 2017 >>> New Revision: 317755 >>> URL: https://svnweb.freebsd.org/changeset/base/317755 >>> >>> Log: >>> Various Coverity fixes in ifconfig(8) >> >> ... >> >>> * Mark usage() as _Noreturn (1305806, 1305750) >> >> ... >> >>> -static void usage(void); >>> +static void usage(void) _Noreturn; >> >> Hi Alan, >> Please use __dead2 instead to be consistent with legacy use of similar gcc attributes. >> Thanks, >> -Ngie > > Why not use _Noreturn? It's standardized by C11, so tools understand > it better than __dead2. Tools that can't understand #define __dead2 _Noreturn aren't worth supporting. Warner