From owner-freebsd-fs@FreeBSD.ORG  Thu Jul  4 19:10:01 2013
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 6B6BCC3D
 for <freebsd-fs@smarthost.ysv.freebsd.org>;
 Thu,  4 Jul 2013 19:10:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 5D75E19A2
 for <freebsd-fs@smarthost.ysv.freebsd.org>;
 Thu,  4 Jul 2013 19:10:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r64JA1Un028439
 for <freebsd-fs@freefall.freebsd.org>; Thu, 4 Jul 2013 19:10:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r64JA17V028438;
 Thu, 4 Jul 2013 19:10:01 GMT (envelope-from gnats)
Date: Thu, 4 Jul 2013 19:10:01 GMT
Message-Id: <201307041910.r64JA17V028438@freefall.freebsd.org>
To: freebsd-fs@FreeBSD.org
Cc: 
From: dfilter@FreeBSD.ORG (dfilter service)
Subject: Re: kern/180236: commit references a PR
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Jul 2013 19:10:01 -0000

The following reply was made to PR kern/180236; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/180236: commit references a PR
Date: Thu,  4 Jul 2013 19:01:25 +0000 (UTC)

 Author: kib
 Date: Thu Jul  4 19:01:18 2013
 New Revision: 252714
 URL: http://svnweb.freebsd.org/changeset/base/252714
 
 Log:
   The tvp vnode on rename is usually unlinked.  Drop the cached null
   vnode for tvp to allow the free of the lower vnode, if needed.
   
   PR:	kern/180236
   Tested by:	smh
   Sponsored by:	The FreeBSD Foundation
   MFC after:	1 week
 
 Modified:
   head/sys/fs/nullfs/null_vnops.c
 
 Modified: head/sys/fs/nullfs/null_vnops.c
 ==============================================================================
 --- head/sys/fs/nullfs/null_vnops.c	Thu Jul  4 18:59:58 2013	(r252713)
 +++ head/sys/fs/nullfs/null_vnops.c	Thu Jul  4 19:01:18 2013	(r252714)
 @@ -554,6 +554,7 @@ null_rename(struct vop_rename_args *ap)
  	struct vnode *fvp = ap->a_fvp;
  	struct vnode *fdvp = ap->a_fdvp;
  	struct vnode *tvp = ap->a_tvp;
 +	struct null_node *tnn;
  
  	/* Check for cross-device rename. */
  	if ((fvp->v_mount != tdvp->v_mount) ||
 @@ -568,7 +569,11 @@ null_rename(struct vop_rename_args *ap)
  		vrele(fvp);
  		return (EXDEV);
  	}
 -	
 +
 +	if (tvp != NULL) {
 +		tnn = VTONULL(tvp);
 +		tnn->null_flags |= NULLV_DROP;
 +	}
  	return (null_bypass((struct vop_generic_args *)ap));
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"