From owner-svn-src-all@freebsd.org Wed Nov 4 16:27:04 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D74A5461010; Wed, 4 Nov 2020 16:27:04 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CRBr83jSbz3yCc; Wed, 4 Nov 2020 16:27:04 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-il1-f182.google.com with SMTP id e16so5507410ile.0; Wed, 04 Nov 2020 08:27:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DlyaYi9G5iLv29pGkbW0EnxAuSioCihwiima4WPz85w=; b=ZQSYswL5eyG5OfAjMfp+Kio4JRLvYaT8Uvzc0US7WVGsO/KzUvz3Wx6f2JoYby9qek epHSyD/FPa7SgMPN1q36SBRj9cZvq6l2Mr4uzNvg3g0FdTJWh4i3NiG4ptYwF6qijzaC 3NxbPoIjhqzmuBDYi381bZT9qyzx1nyb0r82rkWec2jFQwGWgBwpjLMVqp/hKemjJckK +llI5yCE6XEdTB3DyLk/ZEWBvG/B8QTSDBVT3+lPuGdkS3v5Nocv0yM7MxqfQHBcRFFT l10SOhQq0HJt3Y8XVkqYhPwozgvM+kbyY5reByZq8K5Vw3W+foVnYxjcXxx2W4gJV2DF IkLw== X-Gm-Message-State: AOAM530gyrWLjb+CQUanSvfFnOMk1cXYytidKmK7+cfmaBtYf4kpClAx YTnL/vQPd/Nn9OAjnLhY6itPvGBiw3Qou1953gja9XmSXJk= X-Google-Smtp-Source: ABdhPJw2OxUg5gYoE/xuh8k22jw5Vip073SjmmDW2PMAFA8iyiV533l5r23WVLuw6TXwsBDUvGMqGshtByeh10ne01A= X-Received: by 2002:a92:c5a1:: with SMTP id r1mr18435846ilt.11.1604507222894; Wed, 04 Nov 2020 08:27:02 -0800 (PST) MIME-Version: 1.0 References: <202011031957.0A3JvSJ4038311@repo.freebsd.org> In-Reply-To: <202011031957.0A3JvSJ4038311@repo.freebsd.org> From: Ed Maste Date: Wed, 4 Nov 2020 11:26:51 -0500 Message-ID: Subject: Re: svn commit: r367304 - in head: share/man/man5 share/mk tools/build/options usr.bin usr.bin/clang usr.bin/clang/llvm-cxxfilt To: Dimitry Andric Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4CRBr83jSbz3yCc X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2020 16:27:04 -0000 On Tue, 3 Nov 2020 at 14:57, Dimitry Andric wrote: > > Author: dim > Date: Tue Nov 3 19:57:28 2020 > New Revision: 367304 > URL: https://svnweb.freebsd.org/changeset/base/367304 > > Log: > Add WITH_LLVM_CXXFILT option to install llvm-cxxfilt as c++filt A previous argument against the LLVM versions of binutils replacements is that they were excessively large, but this does not look like a substantial problem here. LLVM's cxxfilt is indeed many times the size of ELF Tool Chain's, but still small enough that for a tool chain component it's not a concern, in my opinion. ELF Tool Chain: $ size obj/c++filt text data bss dec hex filename 66966 1008 8400 76374 0x12a56 obj/c++filt LLVM: $ size obj/llvm-cxxfilt text data bss dec hex filename 378138 1756 9165 389059 0x5efc3 obj/llvm-cxxfilt A remaining issue is that both nm and addr2line can also demangle C++ symbols.