From owner-cvs-all  Mon Mar 18 20:14:23 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 7B24C37B405; Mon, 18 Mar 2002 20:14:16 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id PAA16331;
	Tue, 19 Mar 2002 15:14:07 +1100
Date: Tue, 19 Mar 2002 15:14:11 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender:  <bde@gamplex.bde.org>
To: Warner Losh <imp@harmony.village.org>
Cc: <obrien@FreeBSD.org>, Kirk McKusick <mckusick@mckusick.com>,
	<cvs-committers@FreeBSD.org>, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/coda coda_vnops.c src/sys/dev/ccd ccd.c
 src/sys/dev/md md.c src/sys/dev/vinum vinumdaemon.c vinuminterrupt.c
 vinumrequest.c vinumrevive.c src/sys/fs/hpfs hpfs_vnops.c src/sys/f
In-Reply-To: <200203182239.g2IMdGL96585@harmony.village.org>
Message-ID: <20020319150911.H4131-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Mon, 18 Mar 2002, Warner Losh wrote:

> In message <20020318134628.A15033@dragon.nuxi.com> "David O'Brien" writes:
> : On Fri, Mar 15, 2002 at 10:49:47AM -0800, Kirk McKusick wrote:
> : > mckusick    2002/03/15 10:49:47 PST
> : ...
> : >   Log:
> : >   Introduce the new 64-bit size disk block, daddr64_t. Change
> : >   the bio and buffer structures to have daddr64_t bio_pblkno,
> : >   b_blkno, and b_lblkno fields which allows access to disks
> :
> : Objects of type daddr64_t need to be cast to `(long long)' before
> : printing them out with %lld.  Failure to do so adds build warnings on
> : 64-bit hosts.
>
> And on non-64-bit hosts.

On some non-64-bit hosts, but not on i386's.  daddr_t happens to have
type long long on i386's.  Failure to convert %u to %lld was fatal on
on i386's in amr.c and mlx.c.  %u was already doubly wrong: it assmed
that daddr_t is u_int, but daddr_t is actually (signed) int32_t.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message