From owner-freebsd-current Sat May 11 2:34:15 2002 Delivered-To: freebsd-current@freebsd.org Received: from fw.wemm.org (12-232-135-171.client.attbi.com [12.232.135.171]) by hub.freebsd.org (Postfix) with ESMTP id 5B67737B405; Sat, 11 May 2002 02:34:08 -0700 (PDT) Received: from overcee.wemm.org (overcee.wemm.org [10.0.0.3]) by fw.wemm.org (8.11.6/8.11.6) with ESMTP id g4B9Y8445457; Sat, 11 May 2002 02:34:08 -0700 (PDT) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.wemm.org (Postfix) with ESMTP id EC2883808; Sat, 11 May 2002 02:34:07 -0700 (PDT) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Ruslan Ermilov Cc: "David O'Brien" , current@FreeBSD.ORG Subject: Re: cvs commit: src/gnu/lib/csu Makefile src/gnu/lib/libgcc Makefile src/gnu/lib/libiberty Makefile src/gnu/lib/libobjc Makefile src/gnu/lib/libstdc++ Makefile config.h src/gnu/lib/libsupc++ Makefile src/gnu/usr.bin/cc Makefile Makefile.fe Makefile.inc ... In-Reply-To: <20020511074411.GA87663@sunbay.com> Date: Sat, 11 May 2002 02:34:07 -0700 From: Peter Wemm Message-Id: <20020511093407.EC2883808@overcee.wemm.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Ruslan Ermilov wrote: > On Fri, May 10, 2002 at 04:41:53PM -0700, David O'Brien wrote: > > On Fri, May 10, 2002 at 06:04:27PM +0300, Ruslan Ermilov wrote: > > > > Bmake bits for Gcc 3.1. > > > =20 > > > This also vanished my YACC building fixes and broke world while > > > attempting to build `cc1plus' in a cross-tools stage. The changes > > > below fix this and CLEANFILES. > >=20 > > These changes are wrong. > > =20 > These changes have been verified to produce the same binaries > (except for cc1plus which is just broken without them), and > they are equivalent to what was already in -CURRENT before > your WIP_GCC31 merge commit. I dont think you've tested them properly. They will not work. > > > RCS file: /home/ncvs/src/gnu/usr.bin/cc/cc1/Makefile,v > > ... > > > -c-parse.c: c-parse.in > > > +c-parse.y: c-parse.in > > > sed -e "/^ifobjc$$/,/^end ifobjc$$/d" \ > > > -e "/^ifc$$/d" \ > > > -e "/^end ifc$$/d" \ > > > - ${GCCDIR}/c-parse.in > c-parse.y > > > - ${YACC} -o c-parse.c.in c-parse.y > > > - sed -e "s/malloc/xmalloc/g" \ > > > + -e "s/malloc/xmalloc/g" \ > > > -e "s/realloc/xrealloc/g" \ > > > - c-parse.c.in >c-parse.c > > > + ${.ALLSRC} > ${.TARGET} > >=20 > > The malloc usage is in the Byacc output, not the input. > >=20 > There's no difference, [b]yacc just copies C code blocks intact. Do not forget the driver code. There are malloc/calloc calls in the byacc generated c-parse.c.. There are no malloc/calloc calls in the c-parse.in file (see for yourself). If you actually test this, you will get a failure due to 'poisoned' malloc/calloc/etc calls. Cheers, -Peter -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message