From owner-freebsd-bugs@freebsd.org Fri May 14 11:35:52 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 57CBA641DEC for ; Fri, 14 May 2021 11:35:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4FhRL01skcz3KhH for ; Fri, 14 May 2021 11:35:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 3E6D6641DEB; Fri, 14 May 2021 11:35:52 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E37C642075 for ; Fri, 14 May 2021 11:35:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FhRL01CVgz3KvY for ; Fri, 14 May 2021 11:35:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1872C11AE5 for ; Fri, 14 May 2021 11:35:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 14EBZqux039189 for ; Fri, 14 May 2021 11:35:52 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 14EBZqGP039188 for bugs@FreeBSD.org; Fri, 14 May 2021 11:35:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 255868] [PATCH] dev/qlnx/qlnxe: Fix a use after free in ecore_spq_post Date: Fri, 14 May 2021 11:35:52 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: lylgood@foxmail.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2021 11:35:52 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255868 Bug ID: 255868 Summary: [PATCH] dev/qlnx/qlnxe: Fix a use after free in ecore_spq_post Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: lylgood@foxmail.com Created attachment 224932 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D224932&action= =3Dedit change *p_ent to **p_ent in ecore_spq_add_entry() Bug File: sys/dev/qlnx/qlnxe/ecore_spq.c In function ecore_spq_post, p_ent could be freed via ecore_spq_add_entry(..,p_ent,..)->OSAL_FREE(..,p_ent). At the spq_post_fail brach, the freed p_ent is still used by __ecore_spq_return_entry(p_hwfn, p_ent), which is a use after free bug. The root of this uaf bug is that, p_ent is freed in function ecore_spq_add_entry() but failed to be reset to p_en2 by "p_ent =3D p_en2;"= . The p_ent passed to ecore_spq_add_entry() should be **p_ent, instead of *p_ent. My patch fixs that error by a new variable p_en1. --=20 You are receiving this mail because: You are the assignee for the bug.=