From owner-svn-src-head@freebsd.org Mon Aug 10 23:30:40 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4F0299E4B1; Mon, 10 Aug 2015 23:30:40 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [64.62.153.212]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 9AECEBA; Mon, 10 Aug 2015 23:30:40 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from zeta.ixsystems.com (unknown [12.229.62.2]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id D8B8612B17; Mon, 10 Aug 2015 16:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1439249432; x=1439263832; bh=u8wMhO3rTaRSYDRJDv9xjQm4mfzJaWMeAfMz6VmS/8s=; h=Reply-To:Subject:References:To:Cc:From:Date:In-Reply-To; b=pi/j0cLhTGzy2J6Z6Wq3DOLCplNJKh6kyz2bBMdYiD7JDskh4nqbJXuLBf737I8Ni C7Lq+36JIyjWF5iyU4uu7XEEet11M8OrMtzPyLNS7ACruUC0TTK4t2F+Y+lxTvmVit s6F0m3SH7hSc8rybLd400jwDmlbdYxwJZY0G/cYg= Reply-To: d@delphij.net Subject: Re: svn commit: r286601 - head/usr.bin/patch References: <201508102131.t7ALVo5J050735@repo.freebsd.org> To: Ed Schouten , Xin LI Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org From: Xin Li X-Enigmail-Draft-Status: N1110 Organization: The FreeBSD Project Message-ID: <55C93417.80008@delphij.net> Date: Mon, 10 Aug 2015 16:30:31 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QReuH7qSJF5SOArNGMsfhBnWBBsh33GCL" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2015 23:30:40 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QReuH7qSJF5SOArNGMsfhBnWBBsh33GCL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/10/15 14:42, Ed Schouten wrote: > Hi Xin, >=20 > Something I forgot to mention in my previous email: >=20 > 2015-08-10 23:31 GMT+02:00 Xin LI : >> + argp[0] =3D strdup(RCSDIFF); >> + argp[1] =3D strdup(filename); >=20 >> + argp[0] =3D strdup(CHECKOUT); >> + argp[1] =3D strdup("-l"); >> + argp[2] =3D strdup(filename); >=20 > While we're at it, should we also add "--" before the filename, or can > we be sure in this context that they don't start with a dash? We can't be sure. However, neither co nor rcsdiff supports "--", so it won't make a difference. Cheers, --=20 Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die --QReuH7qSJF5SOArNGMsfhBnWBBsh33GCL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1.6 (FreeBSD) iQIcBAEBCgAGBQJVyTQXAAoJEJW2GBstM+ns1LsP/28+tIsZfUJvrk+55a/sHjbc vUwe+FvFVDnlykjnF9Yk6k7ONZdPTUzhx90EU/63+daxTspi61vk2PA6RbjKoD2b IKT3DSUskUKOcUqkFMFMTuPwI5VykgbxzQ9dVL6dG1x3fMjFnN/oxBRqBb4hN/Ro ykbH6hHQds/8blh/ELDUrzHkaWOKEcuk2Ws9pkZH3RX4TM0gO/JI7LloxSINm8BQ udL2q6n55vUDo3qHlFU87w+CyEwRZ7s6x/5XoqFrlq+6tb7iIA73XKgOwooMBBRU v3YV2yqNsh3bEbGhAtco0dno3TR1qyMC2CL5UhVKv98TCLPzfzbeLXr+KyCccbv1 Gc/LWCzT7MEai+ZM3mKUnnTBVNvCjW2AfWDieyTbgdas3W6XxoOdvk3eaXpCpf6d W5wndZ4B/s9u0d6YjlcjHIz89yhuFcVplZaG4zdq7HbEyf2w9UIO9bNyCqM4Z/FI 6/EaNOwC3QHPa7L3V7WBLL0RSfklX9EBELoNj227wEQuXFQh7Wy/pmklXIuXvyMi QD//EZwKxGaa4mdG/x5dOc25kP8Yz+ARLkL9fhFYBmxyTQMrVr5ucOH4limPfxne +YYhSTPJRmmD+vUvvSlWWHJLs9FI6iNYpzSi4IHkTysfs7JFzjNAZdhJIBLL344G CHKEpyPNq6L5XLbf6L/E =m/95 -----END PGP SIGNATURE----- --QReuH7qSJF5SOArNGMsfhBnWBBsh33GCL--