From nobody Thu Apr 6 13:32:54 2023 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Psj9g5L5cz44MZQ; Thu, 6 Apr 2023 13:32:55 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Psj9g3qCpz4QlT; Thu, 6 Apr 2023 13:32:55 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680787975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k1Z54DiNjTuik4aXlg5ApeZOjEVLoUx02i4PclCjOtU=; b=KuHPr8pZBUkvo+j6yATBjH9c5RSH4ns8SbGP6dc0EWx469jKL+JpZpcffvKgcGtci7cJ6W BeoBA718MGtUbaGROLilbhr+qoQv/sgt33gfS8LCOuw9svk46Vheij92bUzZgGxGf3ohJB /MgcvjbHVJXC0A2zVw4exH9OnOhyMxmwjvmlWXhR4VTllsqNNG1m275Nom0cLU+j64X714 wn8KS7y/avZvjT/WoevvYoABruzdXvgSA5ka8KBV0ctiMZVkcFhqkERjXbsovBSFOPkS99 5/2fATWHAQNF3fU3nYnQqxqJXJP1pNwp510Q9bzXdKH4k9tCIyDoQbIQueGnWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1680787975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k1Z54DiNjTuik4aXlg5ApeZOjEVLoUx02i4PclCjOtU=; b=pmj+6/MBv26/V82hqW0oKRxmb4Kn09l3azQQwUWm04Jf9qv1Bz9RQ8/S0KoSc637lkCRiO ETahm5qhIkijNqA390z1SxGhh0FDvmrENoxb8mNr+XuxmjsNfv33mvRwlC4ElRBBXEogca Y7vVuOJaR4ZrLrYPFUhftQvcf4BlibNTKJqHWM78oeZutUXhHkSekJbfbnVjBRrUnrznMN DJAE9o7CxjRz6okKo0cA5vFLNmJNNPu04QVafPCwPDLF4KVfIeJxmisbAv2O6pAlAGNPyG 8pb3YIAX9QODMmF1UQD0KiyPs0lxg8FISySHM70+OtH1y7Ji9yTdSp3Z1ENnlw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1680787975; a=rsa-sha256; cv=none; b=K2zPMfw8jFr5BABJKJkmLzx0SaZVyaIKPF424Kzcz9aJt+JT9WVbyvp1D5F/Z7NEzHZEPA WnPRKpErR9B66nGkP0YK0/DDABWxgLgIG0Nz/HFkKkkK19Y61+WTY7m2L1esGnHfhSXj44 WXcgZe/j3wshzmTXCJFTuzlTOeTDMMrNiCdxP1J8kcfhz7dGbwpofujCyrtbFUDPnArzI9 XmqL/376AUy9RUXOrdS3OkQkDfrU2Sv24MG5Jjkn/Au45dXecZpcyAlkKoF7xYTOjlXJjM sdJzFR+85BTqO+gVB5C73fivXgVN/Fds/ZfvK5KpwTMF95TartfSuuSAseHZXQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 01F24BEC1; Thu, 6 Apr 2023 13:32:54 +0000 (UTC) Date: Thu, 6 Apr 2023 13:32:54 +0000 From: Alexey Dokuchaev To: Guido Falsi Cc: Daniel Engberg , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 72ad532057c9 - main - archivers/zstd: Add CMake config files and adjust Makefile Message-ID: References: <202304050615.3356FKNq062154@gitrepo.freebsd.org> <7accd096-7871-29ad-0824-c035504d01b0@FreeBSD.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N On Thu, Apr 06, 2023 at 03:19:55PM +0200, Guido Falsi wrote: > On 06/04/23 15:17, Alexey Dokuchaev wrote: > > On Wed, Apr 05, 2023 at 02:20:21PM +0200, Guido Falsi wrote: > >> On 05/04/23 08:15, Daniel Engberg wrote: > >>> commit 72ad532057c9f9fb6fa370c80f663c005e9dd021 > >>> > >>> archivers/zstd: Add CMake config files and adjust Makefile > >>> > >>> - Use upstream's short test for "make test" > >>> - Use verbose output by default during build > >>> * Tweak Makefile to follow Porters Handbook more closely > >>> * Install CMake files (taken from CMake build framework) > >>> > >>> PR: 267652 > >>> Reported by: fluffy > >>> Approved by: portmgr (maintainer timeout, 1+ month) > >> > >> Looks like this, un[luckily], causes a failure with devel/qt6-base > >> (abridged error, full log if needed): > >> > >> ld: error: relocation R_X86_64_32 cannot be used against local symbol; > >> recompile with -fPIC > >> >>> defined in /usr/local/lib/libzstd.a(zstd_common.o) > >> >>> referenced by zstd_common.c > >> >>> zstd_common.o:(ZSTD_versionString) in archive > > > > Yeah, I'm seeing this as well. Admittedly, the whole commit looks > > dubious to me, with all these out-of-blue new files and gratuitous > > changes. I guess sunpoet@ should revert it and merge only needed > > parts thereof properly. > > I have only reported the issue as an early warning, as I said. > > Regarding qt6-base a fix has already been proposed here by diizzy: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270664 Ah, good to know it's being taken care of, thanks for sharing! ./danfe