From owner-freebsd-current@FreeBSD.ORG Thu Dec 1 15:04:10 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7AA42106564A; Thu, 1 Dec 2011 15:04:10 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 3B3058FC12; Thu, 1 Dec 2011 15:04:10 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id BF95046B09; Thu, 1 Dec 2011 10:04:09 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 4304CB914; Thu, 1 Dec 2011 10:04:09 -0500 (EST) From: John Baldwin To: Garrett Cooper Date: Thu, 1 Dec 2011 10:04:08 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p8; KDE/4.5.5; amd64; ; ) References: <201111291607.26546.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201112011004.08762.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 01 Dec 2011 10:04:09 -0500 (EST) Cc: Alexander Best , Doug Barton , current@freebsd.org, Warner Losh Subject: Re: Remove debug echo X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2011 15:04:10 -0000 On Thursday, December 01, 2011 2:15:11 am Garrett Cooper wrote: > On Wed, Nov 30, 2011 at 5:59 PM, Garrett Cooper wrote: > > On Wed, Nov 30, 2011 at 5:43 PM, Alexander Best wrote: > >> On Wed Nov 30 11, Garrett Cooper wrote: > >>> On Wed, Nov 30, 2011 at 4:25 PM, Alexander Best wrote: > >>> > On Tue Nov 29 11, Warner Losh wrote: > >>> >> kill it. > >>> >> > >>> >> Warner > >>> >> On Nov 29, 2011, at 2:07 PM, John Baldwin wrote: > >>> >> > >>> >> > Any objections to this? It removes a weird line during 'make -s buildworld' > >>> >> > output and I think it was debugging accidentally left in in 213077 by Warner: > >>> >> > > >>> >> > Index: newvers.sh > >>> >> > =================================================================== > >>> >> > --- newvers.sh (revision 228074) > >>> >> > +++ newvers.sh (working copy) > >>> >> > @@ -99,7 +99,6 @@ for dir in /bin /usr/bin /usr/local/bin; do > >>> >> > done > >>> >> > > >>> >> > if [ -n "$svnversion" ] ; then > >>> >> > - echo "$svnversion" > >>> >> > svn=`cd ${SYSDIR} && $svnversion` > >>> >> > case "$svn" in > >>> >> > [0-9]*) svn=" r${svn}" ;; > >>> > > >>> > also... > >>> > > >>> > when running buildkernel via 'make -s', do we really need all those module > >>> > printfs? i see messages for "cleandir", "obj", "depend" and "all". i think for > >>> > 'make -s', that's pure overkill! > >>> > > >>> > for a GENERIC kernel, 'make' enters ~ 670 module dirs. take that times 4 and > >>> > you'll get 2680 lines of output. not really *silent*, is it? ;) > >>> > >>> pmake sucks as far as diagnostic output is concerned when compared > >>> with gmake. I'd rather not have to fish through with -j1 (if I'm lucky > >>> and it's not a race) to determine what directory created the "Error > >>> Code" output. With the printouts discussed here, at least you have a > >>> chance at determining what the issue was. > >>> Maybe it's just me, but I like noisy builds -- otherwise the > >>> amount of time I have to spend root-causing the issue becomes > >>> expensive. > >> > >> ehmmm...a noisy silent flag? i totally agree, if we're talking about 'make' in > >> its default mode, but what's the point of a silent flag, if it produces > 2500 > >> lines of output? nobody uses the -s flag for diagnostics. its purpose is to > >> build a kernel without producing a lot of output and also not fiddling with > >> stdout/stderr to achieve that goal. > > > > What I really want is this: > > > > $ cat Makefile > > all: foo bar baz yadda > > > > foo bar yadda: > > > > baz: > > false > > $ gmake > > false > > gmake: *** [baz] Error 1 > > ^^^^ > > $ make all > > false > > *** Error code 1 > > > > Stop in /tmp. > > > > Otherwise diagnosing issues becomes a PITA with -j > 1 (with pmake I > > have to start using some serious grep'ing, and if I'm lucky I can find > > the source of error). If I get a few spare cycles I might just > > implement it and post a patch somewhere (the entering and leaving > > directory feature of gmake is really nice too, but it's less > > important.. unless you have the same target in multiple directories).. > > I've attached a patch that makes make do what I would like it to do; > there are some other items that require cleanup to achieve the `argv0' > prefixing that's available in gmake, but this is good enough for a > meaningful traceback when things fail. Pastebin available here, just > in case the mailing list eats my patch: http://pastebin.com/dFqcDRfv I think this is useful, perhaps send it to harti@ or jilles@ for review? -- John Baldwin