From owner-svn-ports-head@freebsd.org Mon Mar 11 07:32:08 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 765451535045; Mon, 11 Mar 2019 07:32:08 +0000 (UTC) (envelope-from meta@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 18F3A87941; Mon, 11 Mar 2019 07:32:08 +0000 (UTC) (envelope-from meta@FreeBSD.org) Received: from icepick.vmeta.jp (unknown [IPv6:2405:6586:2280:1200:bcd7:6ea1:3b39:ada8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: meta/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 7AA64123DA; Mon, 11 Mar 2019 07:32:06 +0000 (UTC) (envelope-from meta@FreeBSD.org) Date: Mon, 11 Mar 2019 16:32:01 +0900 From: Koichiro Iwao To: Tobias Kortkamp Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r495326 - in head/textproc/kibana6: . files Message-ID: <20190311073200.4tvhu6rcam2ipiv4@icepick.vmeta.jp> References: <201903110543.x2B5hKYs027206@repo.freebsd.org> <20190311063230.GA62788@urd.tobik.me> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190311063230.GA62788@urd.tobik.me> X-Operating-System: FreeBSD 12.0-STABLE amd64 User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 18F3A87941 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.96 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_SHORT(-0.96)[-0.960,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2019 07:32:08 -0000 On Mon, Mar 11, 2019 at 07:32:31AM +0100, Tobias Kortkamp wrote: > > @@ -35,14 +35,17 @@ do-install: > > ${RM} -r config node optimize && \ > > ${COPYTREE_SHARE} . ${STAGEDIR}${WWWDIR}) > > ${INSTALL} -lrs ${STAGEDIR}${ETCDIR} ${STAGEDIR}${WWWDIR}/config > > - ${CHMOD} +x ${STAGEDIR}${WWWDIR}/bin/* > > > > post-install: > > ${ECHO} "@sample ${ETCDIR}/kibana.yml.sample" >> ${TMPPLIST} > > ${FIND} -s ${STAGEDIR}${WWWDIR} -not -type d | ${SORT} | \ > > ${SED} -e 's#^${STAGEDIR}${PREFIX}/##' >> ${TMPPLIST} > > + ${REINPLACE_CMD} -e "s|\(${WWWDIR}/bin/.*\)|@mode 0755 \1|" ${TMPPLIST} > > I'm sorry, but this is probably wrong and a noop. There are no > entries starting with WWWDIR in TMPPLIST (${PREFIX} is stripped > from entries in the ${FIND} line above it). I guess it should be > WWWDIR_REL here. @mode also does not take a file argument. Though > that problem is of course never triggered. See pkg-create(8): Indeed, thanks. I meant WWWDIR_REL here but I wasn't aware it is noop. Alternatively, I think COPYTREE_BIN or INSTALL_PROGRAM is another option. > What was wrong with using CHMOD? Actually nothing's going wrong but portlint warned. I aporogize for over optimization. -- meta