From owner-freebsd-current Sat Mar 16 06:20:18 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id GAA05144 for current-outgoing; Sat, 16 Mar 1996 06:20:18 -0800 (PST) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.3/8.7.3) with ESMTP id GAA05139 Sat, 16 Mar 1996 06:20:16 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by time.cdrom.com (8.7.5/8.6.9) with SMTP id GAA00234; Sat, 16 Mar 1996 06:19:54 -0800 (PST) To: davidg@Root.COM cc: David Dawes , sos@FreeBSD.org, dyson@FreeBSD.org, current@FreeBSD.org, mmead@Glock.COM Subject: Re: Try this vm_mmap.c -- please In-reply-to: Your message of "Sat, 16 Mar 1996 06:06:26 PST." <199603161406.GAA07890@Root.COM> Date: Sat, 16 Mar 1996 06:19:53 -0800 Message-ID: <232.826985993@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-current@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk > Could be written as: > > /* > * Force device mappings to be shared. > */ > if (type == OBJT_DEVICE) { > flags &= ~MAP_PRIVATE; > flags |= MAP_SHARED; > } That works too. I wasn't sure whether or not MAP_SHARED should be turned on unilaterally (though John correctly states that specifying neither is an error) so I explictly confined my change to only turning off MAP_PRIVATE (e.g. you could easily come out of that code with neither set). I've tested this change and it works just fine. Commit that baby! :-) Jordan