From owner-freebsd-hackers Fri Sep 7 16:22:47 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 63DF137B406 for ; Fri, 7 Sep 2001 16:22:44 -0700 (PDT) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.6/8.11.1) id f87NMho17176; Fri, 7 Sep 2001 16:22:43 -0700 (PDT) (envelope-from obrien) Date: Fri, 7 Sep 2001 16:22:43 -0700 From: "David O'Brien" To: Bill Swingle Cc: FreeBSD Hackers Subject: Re: tiny patch to pkg_add Message-ID: <20010907162242.A16949@dragon.nuxi.com> Reply-To: obrien@freebsd.org References: <20010907150416.A38565@dub.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010907150416.A38565@dub.net>; from unfurl@dub.net on Fri, Sep 07, 2001 at 03:04:16PM -0700 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Sep 07, 2001 at 03:04:16PM -0700, Bill Swingle wrote: > So this represents my most significant effort to date to fix something > in C. It took me far too long to identify where the one line fix needed > to go and even longer to figure out how to do it in C. > > Here's the problem that this fixes: This was introduced in rev 1.38: and replace a big if..then..else construct to determine the package download directory with a lookup table. I am very tempted to back this part out. This "better implimentation" has now had two logic bugs. I wrote that "big if..then..else contstruct" so that the code would be *so* simple my simple my 1st quarter freshman students (back when I TA'ed) could understand it. I did it that way because I got tired of committers constantly breaking -r. -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message