From owner-freebsd-ports@FreeBSD.ORG  Fri Sep 22 09:42:54 2006
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: freebsd-ports@freebsd.org
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 7DFEC16A47C
	for <freebsd-ports@freebsd.org>; Fri, 22 Sep 2006 09:42:54 +0000 (UTC)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6CBC543D62
	for <freebsd-ports@freebsd.org>; Fri, 22 Sep 2006 09:42:53 +0000 (GMT)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (localhost [127.0.0.1])
	by comp.chem.msu.su (8.13.4/8.13.3) with ESMTP id k8M9gSZ8060078;
	Fri, 22 Sep 2006 13:42:28 +0400 (MSD)
	(envelope-from yar@comp.chem.msu.su)
Received: (from yar@localhost)
	by comp.chem.msu.su (8.13.4/8.13.3/Submit) id k8M9gRmx060076;
	Fri, 22 Sep 2006 13:42:27 +0400 (MSD) (envelope-from yar)
Date: Fri, 22 Sep 2006 13:42:26 +0400
From: Yar Tikhiy <yar@comp.chem.msu.su>
To: Dirk Meyer <dirk.meyer@dinoex.sub.org>
Message-ID: <20060922094226.GC57184@comp.chem.msu.su>
References: <20060821071036.GA44406@comp.chem.msu.su>
	<20060821071036.GA44406@comp.chem.msu.su>
	<44ECBDC0.7000802@FreeBSD.org> <ByX7fGX3bZ@dmeyer.dinoex.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ByX7fGX3bZ@dmeyer.dinoex.sub.org>
User-Agent: Mutt/1.5.9i
Cc: freebsd-ports@freebsd.org
Subject: Re: A section on gettext for the Porter's Handbook
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Sep 2006 09:42:54 -0000

On Fri, Sep 22, 2006 at 06:52:45AM +0200, Dirk Meyer wrote:
> 
> > +.if defined(WITHOUT_NLS)
> > +CONFIGURE_ARGS+=        --disable-nls
> > +PLIST_SUB+=             NLS="@comment "
> > +.else
> > +USE_GETTEXT=            yes
> > +CONFIGURE_ENV=          LDFLAGS="-L${LOCALBASE}/lib"
> > +PLIST_SUB+=             NLS=""
> > +.endif</programlisting>
> 
> Please .. this will break ports which have LDFLAGS= set,
> eg. openssl or database ports.
> To preserve LDFLAGS, the example should be:
> 
> -CONFIGURE_ENV=          LDFLAGS="-L${LOCALBASE}/lib"
> +LDFLAGS+=      	 -L${LOCALBASE}/lib
> +CONFIGURE_ENV+=         LDFLAGS="${LDFLAGS}"

This is a very good point!  Thanks!  I've modified the current
version of the paragraph accordingly.

-- 
Yar