From owner-freebsd-bugs@FreeBSD.ORG Mon Mar 31 03:00:01 2014 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EB2051AD for ; Mon, 31 Mar 2014 03:00:00 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C7C3DB15 for ; Mon, 31 Mar 2014 03:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s2V300rD089486 for ; Mon, 31 Mar 2014 03:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s2V300h6089485; Mon, 31 Mar 2014 03:00:00 GMT (envelope-from gnats) Resent-Date: Mon, 31 Mar 2014 03:00:00 GMT Resent-Message-Id: <201403310300.s2V300h6089485@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jason Unovitch Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 721C9140 for ; Mon, 31 Mar 2014 02:53:34 +0000 (UTC) Received: from cgiserv.freebsd.org (cgiserv.freebsd.org [IPv6:2001:1900:2254:206a::50:4]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5F2D3AD8 for ; Mon, 31 Mar 2014 02:53:34 +0000 (UTC) Received: from cgiserv.freebsd.org ([127.0.1.6]) by cgiserv.freebsd.org (8.14.8/8.14.8) with ESMTP id s2V2rYD5057165 for ; Mon, 31 Mar 2014 02:53:34 GMT (envelope-from nobody@cgiserv.freebsd.org) Received: (from nobody@localhost) by cgiserv.freebsd.org (8.14.8/8.14.8/Submit) id s2V2rYWv057164; Mon, 31 Mar 2014 02:53:34 GMT (envelope-from nobody) Message-Id: <201403310253.s2V2rYWv057164@cgiserv.freebsd.org> Date: Mon, 31 Mar 2014 02:53:34 GMT From: Jason Unovitch To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: conf/188109: [patch] ASSERTION FAILED running individual periodic scripts on 10/11 branches X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Mar 2014 03:00:01 -0000 >Number: 188109 >Category: conf >Synopsis: [patch] ASSERTION FAILED running individual periodic scripts on 10/11 branches >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Mar 31 03:00:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Jason Unovitch >Release: 10.0-RELEASE >Organization: N/A >Environment: FreeBSD xts-bsd 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260789: Thu Jan 16 22:34:59 UTC 2014 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: r254974 introduced the ability to run security periodic scripts on a daily/weekly/monthly basis. It also introduced an assumption that the $PERIODIC variable exported on line 81 /usr/sbin/periodic would be defined. This introduces a minor regression as we cannot run individual scripts by running directly from a shell anymore. >How-To-Repeat: cd /etc/periodic/security ./100.chksetuid ASSERTION FAILED: Unexpected value for $PERIODIC: '' >Fix: Workaround: env PERIODIC=security ./100.chksetuid Fix: Apply attached patch to provide an extra case statement entry for an empty $PERIODIC variable. Patch attached with submission follows: Index: periodic.conf =================================================================== --- periodic.conf (revision 263916) +++ periodic.conf (working copy) @@ -360,6 +360,10 @@ *) return 0 ;; esac ;; + '') + # Run individual scripts from shell + return 0 + ;; *) echo "ASSERTION FAILED: Unexpected value for " \ "\$PERIODIC: '$PERIODIC'" >&2 >Release-Note: >Audit-Trail: >Unformatted: