From owner-freebsd-toolchain@FreeBSD.ORG  Fri Nov  9 15:22:42 2012
Return-Path: <owner-freebsd-toolchain@FreeBSD.ORG>
Delivered-To: toolchain@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 41A1E2EA
 for <toolchain@freebsd.org>; Fri,  9 Nov 2012 15:22:42 +0000 (UTC)
 (envelope-from erik@cederstrand.dk)
Received: from csmtp2.one.com (csmtp2.one.com [91.198.169.22])
 by mx1.freebsd.org (Postfix) with ESMTP id 000178FC12
 for <toolchain@freebsd.org>; Fri,  9 Nov 2012 15:22:41 +0000 (UTC)
Received: from [192.168.1.47] (unknown [176.222.238.90])
 by csmtp2.one.com (Postfix) with ESMTPA id 67919303D04A;
 Fri,  9 Nov 2012 15:22:40 +0000 (UTC)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\))
Subject: Re: arflags cleanup
From: Erik Cederstrand <erik@cederstrand.dk>
In-Reply-To: <A5F62693-7817-4A99-8D45-DC3CE1FAD83B@bsdimp.com>
Date: Fri, 9 Nov 2012 16:22:41 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <E8A733AD-56DE-4FFA-8BA4-BE56D2052BDD@cederstrand.dk>
References: <3D0FBCC4-743C-45B0-82E0-4C82501F7E60@cederstrand.dk>
 <A5F62693-7817-4A99-8D45-DC3CE1FAD83B@bsdimp.com>
To: Warner Losh <imp@bsdimp.com>
X-Mailer: Apple Mail (2.1499)
Cc: "toolchain@freebsd.org" <toolchain@freebsd.org>
X-BeenThere: freebsd-toolchain@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Maintenance of FreeBSD's integrated toolchain
 <freebsd-toolchain.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-toolchain>
List-Post: <mailto:freebsd-toolchain@freebsd.org>
List-Help: <mailto:freebsd-toolchain-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain>, 
 <mailto:freebsd-toolchain-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Nov 2012 15:22:42 -0000

Hello Warner,

Den 09/11/2012 kl. 15.36 skrev Warner Losh <imp@bsdimp.com>:

> On Nov 9, 2012, at 3:52 AM, Erik Cederstrand wrote:
>=20
>> Hello toolchainers,
>>=20
>> I'm attempting to clean up hardcoded ar(1) flags in the tree to use =
the global ARFLAGS in share/mk/sys.mk instead. I want to be able to add =
"-D" to ARFLAGS and have it used everywhere.
>>=20
>> The patch changes some hardcoded flags from e.g. "cru" to the default =
"rl" or "rv" from sys.mk. Looking at the manpage for ar(1), I'm pretty =
sure this is safe, and my runtime tests haven't turned out any problems. =
Loosing the "u" flags means loosing a bit in performance in theory, but =
I have tested this to be negligible in a buildworld / kernel run. In a =
later iteration, maybe the default flags can be added a "u".
>>=20
>> Are there any problems with this patch?
>=20
> I don't like losing the 'c' flag.  Makes things in the build too =
whiny.
> Why purposely lose the 'u' flag that you know helps performance?
> Why move from cq to rl? This can be a big slow down...

I'd actually like to add both 'u' and 'c', I just didn't want to both =
clean up and change the default in the same patch. A followup patch =
could be:


Index: share/mk/sys.mk
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- share/mk/sys.mk	(revision 242822)
+++ share/mk/sys.mk	(working copy)
@@ -39,7 +39,7 @@
 .if defined(%POSIX)
 ARFLAGS		?=3D	-rv
 .else
-ARFLAGS		?=3D	rl
+ARFLAGS		?=3D	cru
 .endif
 RANLIB		?=3D	ranlib


('l' is obsolete).

> What data can you offer that the buildworld run time is negligible?  =
Even on slower platforms?

I don't have any slower platforms available, at least not your =
definition of slower :-)

Erik=