From owner-cvs-all@FreeBSD.ORG  Sun May 30 01:15:53 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id ABDAE16A4CE; Sun, 30 May 2004 01:15:53 -0700 (PDT)
Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 5F20343D45; Sun, 30 May 2004 01:15:53 -0700 (PDT)
	(envelope-from pjd@darkness.comp.waw.pl)
Received: by darkness.comp.waw.pl (Postfix, from userid 1009)
	id 08C29ACADB; Sun, 30 May 2004 10:15:51 +0200 (CEST)
Date: Sun, 30 May 2004 10:15:51 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: David Malone <dwmalone@FreeBSD.org>
Message-ID: <20040530081550.GC12007@darkness.comp.waw.pl>
References: <200405282116.i4SLGin4067490@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="6Nae48J/T25AfBN4"
Content-Disposition: inline
In-Reply-To: <200405282116.i4SLGin4067490@repoman.freebsd.org>
User-Agent: Mutt/1.4.2i
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 5.2.1-RC2 i386
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/kldstat kldstat.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 May 2004 08:15:53 -0000


--6Nae48J/T25AfBN4
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 28, 2004 at 02:16:44PM -0700, David Malone wrote:
+> dwmalone    2004/05/28 14:16:44 PDT
+>=20
+>   FreeBSD src repository
+>=20
+>   Modified files:
+>     sbin/kldstat         kldstat.c=20
+>   Log:
+>   Decide how much space we need to print a pointer using
+>   sizeof(void *) rather than if __alpha__ is defined.
[...]
+> -#if defined(__alpha__)
+> -#define	POINTER_WIDTH	18
+> -#else
+> -#define	POINTER_WIDTH	10
+> -#endif
+> +#define	POINTER_WIDTH	(sizeof(void *) > 4 ? 18 : 10)

Why not just:

#define	POINTER_WIDTH	(sizeof(void *) * 2 + 2)

?

--=20
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd@FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!

--6Nae48J/T25AfBN4
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFAuZg2ForvXbEpPzQRAmPHAKCYLNXpr+IHVTq98oHklfE0F6313gCgiQSA
FqJITc2lbCr7vJhcUEVpIM0=
=Elaj
-----END PGP SIGNATURE-----

--6Nae48J/T25AfBN4--