From owner-svn-src-all@freebsd.org Tue Jul 10 07:52:17 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7B493102CBF4 for ; Tue, 10 Jul 2018 07:52:17 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 005DE87238 for ; Tue, 10 Jul 2018 07:52:16 +0000 (UTC) (envelope-from steven.hartland@multiplay.co.uk) Received: by mail-ed1-x52a.google.com with SMTP id w14-v6so15869930eds.6 for ; Tue, 10 Jul 2018 00:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=mPFbbUnzghFWB+cwzy/4GWELN5lcTAdjhJGi/v++qZE=; b=XD8wYDuvhRtbPsaXgG+GDIpz0+WwkUs90aQrzmtyCmqKS8gtUZ/QTTmTCtrb4aazEO qcb3VeYiaNRPoI4xPWt1w6cbZlDMr+Du7avcqb0bHi/6qCjXiOgkcnxWqEqfPbqIHLAK KilB3lMkruOrEarTtWmXcqHoc5v1CRWG9VRKTNzkJWJLo1+QrgjWFyGtInL8/idzR4HQ KxsyAPRmCRNi+w3Vy8n6YkUONBs/dTLad0LiYNBHEkhqwnjtZPvOJwhdmnVQgraO82lu pN8UBlR5RZN3x/cAgp/bxWgy0ZzkRcEuMkgfJFLm5nJEkOj+tjE19qteZX/+r3HzrJqW PacQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=mPFbbUnzghFWB+cwzy/4GWELN5lcTAdjhJGi/v++qZE=; b=pxWYGD+UJ1hvumiy5CQv2u8jwAvPa1CBif9yHfm1smhOnCSGJQyblOIejE0it6j0ok pzIXuJmVYSRk4qaqCf9rRitzNw2bgUMW2KpeNeWolfipb0BETsIpc3GIWe8bHMLcyrI5 HqtzMX66cBldUgTxkJVlOX0GBVwNKQholZfFmHKCIf+8Xvuvz8ICL5GTAdMBD/OrISAu /F9G/6u8D698VZwaPWMIRjonbkpzBPvrI03DwamGS8oYTyGs8Hiy+Pw8yj5BR+kSdQN7 UkeTuCn4ZcPPzRqKWR0RX7p/eNew1MKsj9xBElgNg5A+sBrw0p4Wn1btkN1OBpDtm3GW 629w== X-Gm-Message-State: APt69E2+fyIsozIEZLaH6J9ZuCbDxBtxssuhEaFsNGmExbr2TigpXDH4 1S0CZXK8UlxfyK0TTEuheGT99Gl6ydY= X-Google-Smtp-Source: AAOMgpfna/adlUKh+jnzKo3HI8DGWIy36pYIRohuPTpyrjtHF1n3pZIppkmRm5zZjuXzu8VzNDPpDg== X-Received: by 2002:a50:a9e2:: with SMTP id n89-v6mr11025005edc.158.1531209135422; Tue, 10 Jul 2018 00:52:15 -0700 (PDT) Received: from [10.44.128.75] ([161.12.40.153]) by smtp.gmail.com with ESMTPSA id s21-v6sm7719556edr.62.2018.07.10.00.52.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jul 2018 00:52:13 -0700 (PDT) Subject: Re: svn commit: r335856 - in head/sys: netinet sys To: rgrimes@freebsd.org, "Jonathan T. Looney" Cc: Matt Macy , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201807021630.w62GUVEQ034521@pdx.rh.CN85.dnsmgr.net> From: Steven Hartland Message-ID: <796f5a04-a4a5-372d-d2ed-4b36d6b04392@multiplay.co.uk> Date: Tue, 10 Jul 2018 08:52:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201807021630.w62GUVEQ034521@pdx.rh.CN85.dnsmgr.net> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2018 07:52:17 -0000 Sorry guys I didn't spot it was just a revert as it was tagged on to the end of the description, I would have expected that to be in the subject. What do others think, is there an recommend style for revert commit messages?     Regards     Steve On 02/07/2018 17:30, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> On Mon, Jul 2, 2018 at 10:44 AM Steven Hartland < >> steven.hartland@multiplay.co.uk> wrote: >>> You have M_WAITOK and a null check in this change >> And, that's the same as the way it was before his commits. So, he did >> exactly what he said he was doing and reverted his commits. I don't think >> it is good practice to mix reverts with other changes. > It is a very bad practive to mix a revert with anything. > >> Since you've noticed this, I think you should feel free to make the change. >> Jonathan