From owner-freebsd-ports@freebsd.org Tue Jul 3 22:57:04 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 205FC103192F for ; Tue, 3 Jul 2018 22:57:04 +0000 (UTC) (envelope-from jbwlists@hilltopgroup.com) Received: from equinox.hilltopgroup.com (equinox.hilltopgroup.com [204.109.63.175]) by mx1.freebsd.org (Postfix) with ESMTP id BDA7975B13 for ; Tue, 3 Jul 2018 22:57:03 +0000 (UTC) (envelope-from jbwlists@hilltopgroup.com) Received: from mail.relativity.hilltop.int (unknown [104.185.205.155]) by equinox.hilltopgroup.com (Postfix) with ESMTP id E389837BDD5 for ; Tue, 3 Jul 2018 18:57:02 -0400 (EDT) Received: from sovereign.sector005 (equinox.hilltopgroup.com [204.109.63.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jbwlists@hilltopgroup.com) by mail.relativity.hilltop.int (Postfix) with ESMTPSA id 7A86916921 for ; Tue, 3 Jul 2018 18:57:02 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=hilltopgroup.com; s=mail; t=1530658622; bh=xvSITMuhdsMsnnY3K6FiZH12TIcUGE1ahynMdb8CPGw=; h=Subject:To:References:From:Date:In-Reply-To; b=hLQnV2DnJOygA9cL6WUGzIR4dHyq9QKlg9a+GX4tl1uUysQieh2sm0oLvwvcUERv7 VQqExBx8nHWsShbXgm+izHlHFqc9rzQp8KSOgYPr3w55WQ4mDuQ6e4PaoKWYD4JtPJ 787LMzFtgkgx2Z36P5YVxV6PY1nYRf5jDnFZ3Kvg= Subject: Re: Battle for wesnoth To: freebsd-ports@freebsd.org References: <8b28e504-79b9-38cf-e8f9-5e43afd6d1fd@davenulle.org> From: Joseph Ward Message-ID: Date: Tue, 3 Jul 2018 18:54:53 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <8b28e504-79b9-38cf-e8f9-5e43afd6d1fd@davenulle.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 22:57:04 -0000 On 07/03/2018 17:38, David Marec wrote: > Hello, > > > Some days ago, the port games/wesnoth was removed from my poudriere > builds, because of boost libraries mismatches I guess. > > So that, I decided to port a newer version of the game (1.14.%) to > FreeBSD. If the port "works for me", it 'be better to provide a > port-tree compliant installation. > > If I'm running FreeBSD for years, it's the first time I am writing a > Makefile for the port tree. > > Thanks to the porters-handbook, (and the original wesnoth Makefile) > I was able to write a Makefile and provides a couple of patches. > One can find the files below: > https://gitlab.com/TurtleCrazy/wesnoth_1_14_freebsd > > Now, as a beginner, I have some questions regarding the Makefile to be > included in the port tree. > > First, the CMake file provides one option to disable the installation > of the game itself. > This might be use to run game servers only. It also avoid the > installation of SDL2 libs. > This option was not defined on the previous port, so I wonder if there > is a need for it. > > > It could be done by adding  the following lines: > > GAME_DESC=    The game client > GAME_CMAKE_OFF=-DENABLE_GAME=off > GAME_USE_SDL= image2 mixer2 net2 ttf2 sdl2 > > > > Second, the pkg-plist is missing. - what makes poudriere testport to > fail. - > > I did not find suitable information in the handbook that explains > how to fill it. Any clue may be helpful. > > > Next, some sets of options requires additional boost libraries. > as > * unit_test_framework > * iostreams program_options regex system thread random > > The Makefile need some reworks to allow fine-grained  dependencies > > > Finally, what about the entry name in the port tree ? > > > > Feel free to correct the code, moreover: be "-pedantic". > > regards, > I can at least help on the pkg-plist file.... in the port directory: make makeplist cp work/.staged-plist pkg-plist you'll have to verify that everything's ok in it, but as long as you didn't do any plist substitutions, I think it'll be fine. -Joseph