From owner-freebsd-toolchain@FreeBSD.ORG Fri May 27 18:14:59 2011 Return-Path: Delivered-To: freebsd-toolchain@FreeBSD.ORG Received: by hub.freebsd.org (Postfix, from userid 1233) id 73206106566B; Fri, 27 May 2011 18:14:59 +0000 (UTC) Date: Fri, 27 May 2011 18:14:59 +0000 From: Alexander Best To: Warner Losh Message-ID: <20110527181459.GA29908@freebsd.org> References: <20110527115147.GA73802@freebsd.org> <3BF63174-1B29-4A4D-96DD-3ED65ED96EAC@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3BF63174-1B29-4A4D-96DD-3ED65ED96EAC@bsdimp.com> Cc: freebsd-hackers@FreeBSD.ORG, freebsd-toolchain@FreeBSD.ORG Subject: Re: [rfc] a few kern.mk and bsd.sys.mk related changes X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 May 2011 18:14:59 -0000 On Fri May 27 11, Warner Losh wrote: > These look generally good. Just one thing I had a question on: > > # > +# Enable FreeBSD kernel-specific printf format specifiers. Also instruct gcc to > +# enable some diagnostics, which make it easier to pinpoint tinderbox failures. > +CFLAGS+= -fformat-extensions -fdiagnostics-show-option > + > > Does this put sand in the gears of clang support? i don't think so. the code that features -fformat-extensions support is freebsd specific and gets plugged into the vendor code during every new import. dim@ and rdivacky@ have been discussing the possibility of getting this committed upstream as something like -ffreebsd-extensions, but they haven't decided, yet. regarding -fdiagnostics-show-option: this is intended purely for gcc, since it is disabled per default. under clang the flag exists, too, but it is enabled by default. so specifying it under clang is pretty much a nop. cheers. alex > > Warner > > > On May 27, 2011, at 5:51 AM, Alexander Best wrote: > > > hi there, > > > > i would like to hear people's opinion regarding the following patch. it > > features the following semantic changes: > > > > 1) -W is now called -Wextra > > 2) move -fformat-extensions and -fdiagnostics-show-option out of CWARNFLAGS, > > since they aren't really warnings. this will now let anybody use custom > > CWARNFLAGS without having to remember to add -fformat-extensions in order > > not to break buildworld. > > 3) rearrange "\" characters, as to avoid double spaces > > 4) when building kernel modules, -fstack-protector was added to CFLAGS twice. > > this should now be solved. > > > > cheers. > > alex > > > > -- > > a13x > > _______________________________________________ > > freebsd-toolchain@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain > > To unsubscribe, send any mail to "freebsd-toolchain-unsubscribe@freebsd.org" -- a13x