From owner-svn-src-all@FreeBSD.ORG Tue Dec 8 14:36:32 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E9EBF1065672; Tue, 8 Dec 2009 14:36:32 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bw0-f213.google.com (mail-bw0-f213.google.com [209.85.218.213]) by mx1.freebsd.org (Postfix) with ESMTP id 1BE518FC13; Tue, 8 Dec 2009 14:36:31 +0000 (UTC) Received: by bwz5 with SMTP id 5so4428403bwz.3 for ; Tue, 08 Dec 2009 06:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=+8/Zv/7PVKnPws0Fb8ipDiuB21KzsH2Yv6NDuc8328E=; b=jRkYDABdt2zFX7oS/Rv+kjGmqwGTvFOtWSOtt0vmG4uPuomIiEM78DixKc9eTxOrxW VW0dxjsZEgSyRfQ4aY55870Eu1s46UHSTDbTwzE6wqGuQ0+TC73yn25CEE9cssLfz9YP q6mym1b20pPNkWlR7LETpmy9XCRiCpOqmf6Co= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=A5BK54+9yO3QGDWqzfbINr+HFvHkU/DltNkwXtNymHQN18JQSW1q83UX59fEA1sOEx 0ImC2mJN9tcy2WxrlN3/x/Qw+gAjOvQuaBEaS0jGCfE9/MzTX752OLRZiLLHOvT+tu3q jss7QWCzJjTh9WBNCQ/92uO+tMxUlSEPtRGIs= Received: by 10.204.25.19 with SMTP id x19mr4917103bkb.189.1260282990996; Tue, 08 Dec 2009 06:36:30 -0800 (PST) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id 13sm2377186fxm.1.2009.12.08.06.36.29 (version=SSLv3 cipher=RC4-MD5); Tue, 08 Dec 2009 06:36:30 -0800 (PST) Sender: Alexander Motin Message-ID: <4B1E646B.8050209@FreeBSD.org> Date: Tue, 08 Dec 2009 16:36:27 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20090901) MIME-Version: 1.0 To: src-committers@freebsd.org References: <200912051340.nB5DepkE089078@svn.freebsd.org> <20091207174233.GG1688@garage.freebsd.pl> In-Reply-To: <20091207174233.GG1688@garage.freebsd.pl> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r200121 - head/sys/dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2009 14:36:33 -0000 Pawel Jakub Dawidek wrote: > On Sat, Dec 05, 2009 at 01:40:51PM +0000, Alexander Motin wrote: >> Author: mav >> Date: Sat Dec 5 13:40:51 2009 >> New Revision: 200121 >> URL: http://svn.freebsd.org/changeset/base/200121 >> >> Log: >> Do not ignore device interrupt if bus mastering is still active. It is >> normal in case of media read error and some ATAPI cases, when transfer size >> is unknown beforehand. PCI ATA BM specification tells that in case of such >> underrun driver should just manually stop DMA engine. DMA engine should >> same time guarantie that all bus mastering transfers completed at the moment >> of driver reads interrupt flag asserted. >> This change should fix interrupt storms and command timeouts in many cases. >> >> PR: kern/103602, sparc64/121539, kern/133122, kern/139654 > > I've a box where I see interrupt storm on. This is 8-STABLE with this > patch applied. Pawel found that it was not ATA issue, but USB. Fixed. -- Alexander Motin