From owner-freebsd-java@FreeBSD.ORG Sun Dec 8 04:12:47 2013 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 512B9604 for ; Sun, 8 Dec 2013 04:12:47 +0000 (UTC) Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E171A1FAC for ; Sun, 8 Dec 2013 04:12:46 +0000 (UTC) Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.14.7/8.14.7) with ESMTP id rB84CiOb065556; Sat, 7 Dec 2013 20:12:45 -0800 (PST) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.14.7/8.14.7/Submit) id rB84Ci9K065555; Sat, 7 Dec 2013 20:12:44 -0800 (PST) (envelope-from glewis@eyesbeyond.com) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Sat, 7 Dec 2013 20:12:43 -0800 From: Greg Lewis To: Albert Shih Subject: Re: 7u45 update - amd64 testers Message-ID: <20131208041243.GA65544@misty.eyesbeyond.com> References: <20131207064044.GA79133@misty.eyesbeyond.com> <20131207092231.GA51378@pcjas.obspm.fr> <20131207190545.GA87007@misty.eyesbeyond.com> <20131207193105.GA17749@misty.eyesbeyond.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131207193105.GA17749@misty.eyesbeyond.com> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: freebsd-java@freebsd.org X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Dec 2013 04:12:47 -0000 On Sat, Dec 07, 2013 at 11:31:05AM -0800, Greg Lewis wrote: > On Sat, Dec 07, 2013 at 11:05:45AM -0800, Greg Lewis wrote: > > On Sat, Dec 07, 2013 at 10:22:31AM +0100, Albert Shih wrote: > > > Le 06/12/2013 ? 22:40:44-0800, Greg Lewis a ?crit > > > > Can someone please download > > > > > > > > http://people.freebsd.org/~glewis/openjdk7-7u45.diff > > > > > > > > and see if it compiles on amd64? If it does I'll go ahead and commit it. > > > > Already tested on i386 locally. > > > > > > No that's not compiles. > > > > > > On : > > > > > > 9.2-STABLE FreeBSD 9.2-STABLE #11 r258722: Thu Nov 28 23:37:54 CET 2013 > > > > > > kernel /usr/obj/usr/src/sys/GENERIC amd64 > > > > > > all ports is up2date. > > > > > > Here the logs. > > > > > > Thanks for your work. > > > > Thanks Albert. That actually looks like a 8.x vs. 9.x problem. It needs > > to be fixed regardless. > > > > On 8.x: > > > > typedef struct sem * sem_t; > > > > On 10.x (and presumably 9.x as well based on the error) > > > > typedef struct _sem sem_t; > > > > I think the solution is to vary the os_semaphore_t definition in os_bsd.cpp > > based on the FreeBSD version. Let me test compiling that on 8.x and I'll > > send it out. > > Actually, maybe it's as simple as this. Can someone give the following a > try on a 9.x machine? Preferably amd64 since I still want to make sure > we're ok there. > > diff -r 54995aa29dbb src/os/bsd/vm/os_bsd.cpp > --- a/src/os/bsd/vm/os_bsd.cpp Wed Dec 04 22:06:37 2013 -0800 > +++ b/src/os/bsd/vm/os_bsd.cpp Sat Dec 07 11:29:16 2013 -0800 > @@ -2755,7 +2755,11 @@ > os_semaphore_t _semaphore; > }; > > +#if defined(__FreeBSD__) && __FreeBSD__ > 8 > +Semaphore::Semaphore() : _semaphore() { > +#else > Semaphore::Semaphore() : _semaphore(0) { > +#endif > SEM_INIT(_semaphore, 0); > } > I got private confirmation that worked for 9-amd64 so I've committed it. Please let me know if you have any problems. -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org