From owner-dev-commits-src-all@freebsd.org Tue Mar 16 02:44:37 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5B73A57493D; Tue, 16 Mar 2021 02:44:37 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DzyLF275dz4sHQ; Tue, 16 Mar 2021 02:44:37 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1615862677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pVKqIpCHol5Q2V2RgMSjKCOIr7dnc3L4G8xm0kve/q4=; b=vDjfe7+IS3YS6P9zIxy8y3i3D6mDweWnN93dNWpDU0d62h409ZSfiVriPNg/Ft0G5Y0zKZ 1QeRnOmcdigc3xDOLWKJ4uRCZmM8zsK72FtcXgJ0XRqHefuY4nU3bRnMnIzdkC09ieBsJy Lv8w9IGCpVhhM15DzQR6YuFnYvzFF2c9srA3HAn7Rmaq9Hs8INRQa5QMfLGCyNr4JIUsZG KRYDnhLbWnLIFY7KOij9Gm966wUauzRSl8jk2oxRBbbU/gC+bA8b0HpnGEv7RZigOYADZ7 1olrNL7Q4HaS8YCAVv/qzGMHzFrDWYuDvr7Kv4o5RhDdKHnF+CmcvoGYTQu66A== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 36723F06A; Tue, 16 Mar 2021 02:44:37 +0000 (UTC) Date: Tue, 16 Mar 2021 02:44:37 +0000 From: Alexey Dokuchaev To: Scott Long Cc: Kyle Evans , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 74ae3f3e33b8 - main - if_wg: import latest fixup work from the wireguard-freebsd project Message-ID: <20210316024437.GA60113@FreeBSD.org> References: <202103150452.12F4qxjV047368@gitrepo.freebsd.org> <13F91280-2246-4A7B-BAC2-B9ABA07B561F@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13F91280-2246-4A7B-BAC2-B9ABA07B561F@samsco.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1615862677; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pVKqIpCHol5Q2V2RgMSjKCOIr7dnc3L4G8xm0kve/q4=; b=m2ZHBEEBRYb6SaadBr95wIYeMVsqZn/fEPRvQ65DFy8lxLCHnpDzjaQ+O1jOAbjCeUS77O rOUHL/OAO3B4W0dgbw8BXFO3uaRpVOH/rQ1Ptwo9gTI0UWzOaH+uqa/BOiwoACvP+IIL5l m0OCQ5x3IGFbxb04PAB5fE2d5k5SS8TnnCM9KoaYZjPIflxZsKVMGj5eh6MmKNDpV2+XDF 6jvqK2VqV8OnNqlahC5dStYEzMqoGtuaTIszxbqK5HZpH3rmOQ4Zut3579a009DiHktnox 6vYY1QKuy8sYf4FiTAUSqr3GDm4cGUkAD0XBmb3EnMYgwl0HmtB0vUNtARqrRQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1615862677; a=rsa-sha256; cv=none; b=tW1xF8EKVXMA1/Zupo93DP9Swthc2PEX22Kl4At8MFMxAAErEkJOHGHbOBPeGbO38ilpim /MWh3CpsfKTloF/sAH0b6UqxXc4aWXdeWhXh/jaXBeeaLB23nCMKKV80DVUHB1YSegVgyU u2QrrPJunbegw+AEh4XHk34Bd58FhvP7zK2Ln6cG6t0/cH7uLpivnbKBYPQh6kWdn9f02D /ljJXCXta1TUHXIyFl3EBxhv5DVj7mNRfejjwy6c3GQyDq8fBEtiiuitBUqMyRrX2HG2AT IneNZuxBmrLj4Nq8mfYq9AsLfedBgBs5OOYYpZuPt8aMsBZC24P7qG267Rh/nQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 02:44:37 -0000 On Mon, Mar 15, 2021 at 08:56:56AM -0600, Scott Long wrote: > Here is the response I sent to you and Donenfeld in private. I won't > include my direct conversation with you from Slack/IRC, but I made my > concerns and objections pretty clear. This commit is quite > disappointing. FWIW, original wireguard commit seemed more disappointing to me. > - The LKML wouldn't accept this kind of submission, they'd insist > that it be broken down into consumable pieces, and that bug fixes be > considered and provided that don't rely on massive re-writes. Didn't Linux folks also refuse to accept wireguard code until it was ported from some home-grown "hey, let's do crypto stuff ourselves!" implementation to their standard kernel APIs? > - An accusation was made, tonight, to me, that the code Netgate > sponsored was not reviewed and was shoved into the tree at the last > minute. This grossly ignores the actual history to the point of > weakening my tolerance for this entire discussion. It shows a > pretty irrational bias against mmacy [...] Slightly tangential note, but my questions to mmacy@ about original wireguard commit (and ZoL, FWIW) or Phabricator comments had not been answered; I also recall reviews being closed in "not accepted" state by him. While I appreciate the heavy-lifting, developers should be ready to explain and sometimes defend their work on public forums. > - The removal of the ASM crypto bits really confuses me. But addition of the new crypto code, bypassing our crypto framework in the first place did not? Anyway, I'm really happy to see Jason's work; looks like sanity is something FreeBSD can, once again, be known for. ;-) ./danfe