From owner-svn-src-all@FreeBSD.ORG  Tue Apr 21 18:51:22 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C574E10656BC;
	Tue, 21 Apr 2009 18:51:22 +0000 (UTC) (envelope-from das@FreeBSD.ORG)
Received: from zim.MIT.EDU (ZIM.MIT.EDU [18.95.3.101])
	by mx1.freebsd.org (Postfix) with ESMTP id 80ECB8FC0A;
	Tue, 21 Apr 2009 18:51:22 +0000 (UTC) (envelope-from das@FreeBSD.ORG)
Received: from zim.MIT.EDU (localhost [127.0.0.1])
	by zim.MIT.EDU (8.14.3/8.14.2) with ESMTP id n3LIsawB018764;
	Tue, 21 Apr 2009 14:54:36 -0400 (EDT) (envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by zim.MIT.EDU (8.14.3/8.14.2/Submit) id n3LIsa7W018763;
	Tue, 21 Apr 2009 14:54:36 -0400 (EDT) (envelope-from das@FreeBSD.ORG)
Date: Tue, 21 Apr 2009 14:54:36 -0400
From: David Schultz <das@FreeBSD.ORG>
To: Roman Divacky <rdivacky@FreeBSD.ORG>
Message-ID: <20090421185436.GA18628@zim.MIT.EDU>
Mail-Followup-To: Roman Divacky <rdivacky@FreeBSD.ORG>,
	src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	svn-src-head@FreeBSD.ORG
References: <200904201819.n3KIJcZo054306@svn.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200904201819.n3KIJcZo054306@svn.freebsd.org>
Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG,
	src-committers@FreeBSD.ORG
Subject: Re: svn commit: r191330 - head/usr.bin/ncal
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 21 Apr 2009 18:51:23 -0000

On Mon, Apr 20, 2009, Roman Divacky wrote:
> Author: rdivacky
> Date: Mon Apr 20 18:19:38 2009
> New Revision: 191330
> URL: http://svn.freebsd.org/changeset/base/191330
> 
> Log:
>   Implement highlighting of today in month view of cal/ncal just like
>   gnu cal does. This is currently disabled for year view because of hard
>   coded padding in that case. This will hopefully be fixed soon.

As I recall, ncal relies on the length of each line it formats to
take care of alignment issues in various places. Are you sure that
adding control characters doesn't break that?

Also, before this change, ncal was already full of convoluted
buffer handling, arbitrary buffer sizes, and little to no bounds
checking. This commit adds more magic numbers and fragile buffer
handling code, and generally makes an already hairy program even
less scrutable. This isn't your fault, but it would be nice if we
could make ncal better before it gets much worse. For instance,
you might use snprintf() or asprintf() instead of an extra half
dozen calls to memcpy() with various offsets.