From owner-p4-projects@FreeBSD.ORG Fri Jun 15 15:38:17 2007 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 83B8016A46E; Fri, 15 Jun 2007 15:38:17 +0000 (UTC) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4A20316A400; Fri, 15 Jun 2007 15:38:17 +0000 (UTC) (envelope-from lulf@FreeBSD.org) Received: from merke.itea.ntnu.no (merke.itea.ntnu.no [129.241.7.61]) by mx1.freebsd.org (Postfix) with ESMTP id 07B2A13C4B0; Fri, 15 Jun 2007 15:38:17 +0000 (UTC) (envelope-from lulf@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by merke.itea.ntnu.no (Postfix) with ESMTP id 8144713DAB2; Fri, 15 Jun 2007 17:18:02 +0200 (CEST) Received: from twoflower.idi.ntnu.no (twoflower.idi.ntnu.no [129.241.104.169]) by merke.itea.ntnu.no (Postfix) with ESMTP; Fri, 15 Jun 2007 17:18:02 +0200 (CEST) Received: by twoflower.idi.ntnu.no (Postfix, from userid 1002) id 4540717023; Fri, 15 Jun 2007 17:18:02 +0200 (CEST) Date: Fri, 15 Jun 2007 17:18:02 +0200 From: Ulf Lilleengen To: Pawel Jakub Dawidek Message-ID: <20070615151802.GA19594@twoflower.idi.ntnu.no> References: <200706122057.l5CKvKlc084001@repoman.freebsd.org> <20070615124940.GB37295@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070615124940.GB37295@garage.freebsd.pl> User-Agent: Mutt/1.5.15 (2007-04-06) X-Content-Scanned: with sophos and spamassassin at mailgw.ntnu.no. Cc: Perforce Change Reviews Subject: Re: PERFORCE change 121535 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2007 15:38:18 -0000 On Fri, Jun 15, 2007 at 02:49:40PM +0200, Pawel Jakub Dawidek wrote: > On Tue, Jun 12, 2007 at 08:57:20PM +0000, Ulf Lilleengen wrote: > > http://perforce.freebsd.org/chv.cgi?CH=121535 > > > > Change 121535 by lulf@lulf_carrot on 2007/06/12 20:57:13 > > > > - Allow subdisks to be added to raid5 plexes again. > > - Add detach to userland gvinum tool > > - Add gv_detach general request handler for detaching > > - Add gv_detach_sd and gv_detach_plex to detach a subdisk and a plex. > > - Make gv_sd_to_plex use the standard plex-size calculation. > > - Add a sddetached-variable to gv_plex do be able to detect wether a > > plex misses a subdisk or not. This variable is increased when a > > subdisk is detached, and increased when a subdisk is attached. > > - Remove weird offset-check with a correct one. > > - Hook it up in the event system. > > - Looks like handling a crashed drive, and replacing it is working so > > far! > > What do you use to test this? If you're not using it now, you should try > gnop(8). You can simulate disk removal and I/O errors. It proved to be > very handy for me in the past. > I do a dd if=/dev/zero of=/dev/ which makes gvinum "loose" the drive. But thanks for the tip. It can perhaps give me ability to test more than just removal. -- Ulf Lilleengen