From owner-svn-ports-head@FreeBSD.ORG Tue Jul 9 06:31:20 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9E7449FA for ; Tue, 9 Jul 2013 06:31:20 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-ve0-x235.google.com (mail-ve0-x235.google.com [IPv6:2607:f8b0:400c:c01::235]) by mx1.freebsd.org (Postfix) with ESMTP id 5A3E01ADD for ; Tue, 9 Jul 2013 06:31:20 +0000 (UTC) Received: by mail-ve0-f181.google.com with SMTP id db10so4197928veb.26 for ; Mon, 08 Jul 2013 23:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=38avMeMILbOYZ9dMTo5cEbYA9NzZ37lROTSBzgPU0kI=; b=owcXW9k+BkD0kYkSsxwUa9Oiv5+t5idojAmnRoWJDIGXpUuuydrxthi0g9JNXNvrtR 0+/z+iST5NvvWNzQKrwHEXdLR7hFo+iHaPUXmZ4LqegX5AHI0nmM7hntKknLNf6SoDnk /85EYp9gaTcLi/Rm8zdEU3wLF8hXIEh4sNN/g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=38avMeMILbOYZ9dMTo5cEbYA9NzZ37lROTSBzgPU0kI=; b=GzAeRBNUXGDqWeEUHq8K1KVvyd+wxt+AhUtJud/9LboazY4H0HYjOl5NIzO1yUSBKd ChwbcjBkQCtLYo041QgkL8vzZzvIRI2z3JaceF+bdTj4//HN0jDnjP0nDRDFSsXQGAU9 A7kJv5t5U2cJYJkPd82FYRNLPHCOpBQQHfKyzjmI/vVNEZyN9wgdJmTt1hO3e72yNsIw SeEazQzRJtACHa+3Tw179vE3zDV1co3DkP13LMwIRwTKYog+wb2j02KiFyhe++7NHL7B yq/yECHWS0CFdMFs+qy6WniyiMcpTYeRZdNSQcsm4ee8zJXIlH35NcEis8tkP64s0ZIj 9AKg== X-Received: by 10.220.70.76 with SMTP id c12mr15427080vcj.8.1373351479814; Mon, 08 Jul 2013 23:31:19 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.220.118.206 with HTTP; Mon, 8 Jul 2013 23:30:49 -0700 (PDT) In-Reply-To: <20130709062239.GA76101@FreeBSD.org> References: <201307071532.r67FWZTH036372@svn.freebsd.org> <51D98A76.7090505@FreeBSD.org> <51DB0777.8080300@FreeBSD.org> <08cbb4c709544cad3671c093558910bb@mail.adamw.org> <51DB2DB9.1070104@FreeBSD.org> <20130709011838.GA7501@FreeBSD.org> <20130709062239.GA76101@FreeBSD.org> From: Eitan Adler Date: Tue, 9 Jul 2013 08:30:49 +0200 X-Google-Sender-Auth: GHRCum-4DT-CUt6-dwFuIM8W-2g Message-ID: Subject: Re: svn commit: r322444 - head/Tools/scripts To: Alexey Dokuchaev Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQnPOm/DnmRwblb7g+Xft4Byc9ISXFGzu+3hbeQKAgywHg6ynbAc9Pnu5WGA9p2oL+HxtcwO Cc: svn-ports-head@freebsd.org, owner-ports-committers@freebsd.org, svn-ports-all@freebsd.org, Bryan Drewery , ports-committers@freebsd.org, Adam Weinberger X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jul 2013 06:31:20 -0000 On Tue, Jul 9, 2013 at 8:22 AM, Alexey Dokuchaev wrote: > On Tue, Jul 09, 2013 at 08:06:36AM +0200, Eitan Adler wrote: >> On Tue, Jul 9, 2013 at 3:18 AM, Alexey Dokuchaev wrote: >> > So is d4p port itself. Why not just bundle it there? Mk/ is not really >> > for helper shell scripts, even critical ones. >> >> Why not? > > 1) Because Mk/ is for make(1) code, while this is a shell script? Dividing code based on language seems silly to me. > 2) It looks more like some part of d4p, rather than some part of b.p.m. So then it should be distributed with d4p. In any case this script is critical for interacting with the ports tree. ... I don't really care where this script ends up. I thought it would be better to have in a place which didn't seem to indicate "this is a third party helper script" but if the bikeshed is going to take more than 1 person to paint lets just drop it. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams