From owner-freebsd-current Thu Nov 14 10:27:40 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BDCD737B401; Thu, 14 Nov 2002 10:27:38 -0800 (PST) Received: from spider.deepcore.dk (cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0C89B43E77; Thu, 14 Nov 2002 10:27:31 -0800 (PST) (envelope-from sos@spider.deepcore.dk) Received: (from sos@localhost) by spider.deepcore.dk (8.12.5/8.12.6) id gAEIRRQG026591; Thu, 14 Nov 2002 19:27:27 +0100 (CET) (envelope-from sos) From: Soeren Schmidt Message-Id: <200211141827.gAEIRRQG026591@spider.deepcore.dk> Subject: Re: /dev/acd*t* no longer available in -current? In-Reply-To: <20021115011200.E10490-100000@gamplex.bde.org> To: Bruce Evans Date: Thu, 14 Nov 2002 19:27:27 +0100 (CET) Cc: Conrad Sabatier , freebsd-current@FreeBSD.ORG, freebsd-multimedia@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL98b (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG It seems Bruce Evans wrote: > Single-digit track numbers are correct and are still generated by MAKEDEV. Single digit track numbers are wrong and should be fixed in MAKEDEV. > The devfs numbers were broken in: > > % RCS file: /home/ncvs/src/sys/dev/ata/atapi-cd.c,v > % Working file: atapi-cd.c > % head: 1.126 > % ... > % ---------------------------- > % revision 1.119 > % date: 2002/05/28 17:39:17; author: sos; state: Exp; lines: +1 -1 > % Use %02d in track numbers, so that 1 is 01, much easier for scripts > % ---------------------------- > > Contrary to the log message, %02d is harder for scripts. It gives many > more cases to handle: > - %d format under RELENG_4 Should be fixed. > - %d format under -current in the non-devfs case DEVFS should be considered mandatory for the track devices on current. > - %d format under -current even in the devfs case for track numbers >= 100 BZZT!! there can be a max of 99 tracks on a CD. > - %02d under -current in the devfs case for track numbers < 100. Thats actually the one thats right :) > The following patch backs out rev.1.119 of atapi-cd.c and fixes the > following older devfs bugs in acd: > - insecure permissions. Among other holes, these allowed the world to > erase cd-rw's. Use rc.devfs for that as it was intended. > - hard-coded ownerships leading to broken groups for the track devices. Well, that sounds like a bug alright... -Søren To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message