From owner-cvs-all@FreeBSD.ORG Tue Apr 15 07:51:50 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 352E337B401; Tue, 15 Apr 2003 07:51:50 -0700 (PDT) Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6239143FB1; Tue, 15 Apr 2003 07:51:49 -0700 (PDT) (envelope-from mdodd@FreeBSD.ORG) Received: from sasami.jurai.net (sasami.jurai.net [66.92.160.223]) by sasami.jurai.net (8.12.9/8.12.9) with ESMTP id h3FEpkEF017377; Tue, 15 Apr 2003 10:51:46 -0400 (EDT) (envelope-from mdodd@FreeBSD.ORG) Date: Tue, 15 Apr 2003 10:51:46 -0400 (EDT) From: "Matthew N. Dodd" X-X-Sender: winter@sasami.jurai.net To: "M. Warner Losh" In-Reply-To: <20030415.083615.91276433.imp@bsdimp.com> Message-ID: <20030415104824.H99028@sasami.jurai.net> References: <20030414124016.O39446@sasami.jurai.net> <20030415.082727.65119004.imp@bsdimp.com> <20030415.083615.91276433.imp@bsdimp.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: sobomax@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: cvs-src@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/fxp if_fxp.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Apr 2003 14:51:50 -0000 On Tue, 15 Apr 2003, M. Warner Losh wrote: > How do you tell if a BAR is enabled? I assume you mean 'check to see > if the BAR has an allocated resource' here? In that case, my XXX > applies :-( We should allocate a resonable resource. Actually I misspoke; we should modify pci_enable_io_method() so that we can indicate a failure to enable the requested space. This would keep drivers from having to check and see if PCIM_CMD_PORTEN or PCIM_CMD_MEMEN is set. This requires changing the definition of the 'enable_io' method. Since we're here we should change 'disable_io' and '{enable,disable}_busmaster' as well. -- | Matthew N. Dodd | '78 Datsun 280Z | '75 Volvo 164E | FreeBSD/NetBSD | | winter@jurai.net | 2 x '84 Volvo 245DL | ix86,sparc,pmax | | http://www.jurai.net/~winter | For Great Justice! | ISO8802.5 4ever |