From owner-svn-src-head@freebsd.org Thu Jan 30 19:04:12 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7F5791FAA40 for ; Thu, 30 Jan 2020 19:04:12 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 487qXD12HBz4W4K for ; Thu, 30 Jan 2020 19:04:11 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1580411050; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=cdkZDFc8fPnvIpRgAnd+rEsMsLk6f3S0KVZKaeDnrph+mLCa2Q9VbCOQ5RiihDihQvjTypjWLs2Fc oum0CCUCOM6DZfgHCiuThY+n8qSDKflRx8w7cRgS4AnEfol7mbJPKkPFXKqE3jrHWXiwoW2vb22Hxr YqbvhbQJuNTX6aD08PjXinWa7mN7v+jaw4IVu86iU5RnB/E7yaPvmYDuEJB1vA6trcpNFHmBUeZQ7B X1djhx4/d2AEy39hHxD40G3dg+tPyTamvBwym0QL6rr/qZIy0P/Lh+dqzJ6UO9RVGuy2Y/KelYde/S TdiJ8/Jp31aBxhjCwMexpikxV9N6yLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:dkim-signature:from; bh=EuzSx73AuuXx5VKBaVaZH3a3AW4grDotd44WHI5kV/Q=; b=DTHdPRHyOs7y10PM1YaYDtiJ4HsLgdHHhoGH2HSPtp6GAGCOgkjHIyve+Yt3Vmid9NOrxV+6l36am bGMFv4jd09GIwXELfQGwL8flKAxoTilA+SPiuzZW9cvO1ab/WgOUypfiwf2hDjeiOwBcPWP0xK6cOo P91K3QcGdE9Dc3Le3ZJMgcYUp3QYUkNcsbn6QLbVIQ3XNZ6f6DVz/aGuSPTZFB64WWxqybLBSEmDGL p5OQ5IsK0ngPhbp2C7lpG5s13++0cUwGuSPkqwPwb3spnuvkqcgZEw9sIcZ3zObHkdjTRCurX9ZvAB KyXXU2SAhZbN5YBapoi5JEghRDwygFA== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:to:from:subject:message-id:from; bh=EuzSx73AuuXx5VKBaVaZH3a3AW4grDotd44WHI5kV/Q=; b=bi4/UPSh1HLb/F/4pA7f0E9XAPvlWs5RdAfw8c9/A1TMDOD0athqJK65wk+9DSTKgYbvDgNyx5dkE nhXdspgjZWiaSFAvbKTbVvtULDISEQDByOtzNRAC1dFDuysE9NGfQzjito6J0mkHQh0nfhInVO7fPV 820DS88QX0hLS9Cs7Swgl2UAbnSJ/OqypJOg5+IevHisV4C3s5OTgsRi7U6G7cNS/G5Xf0K5l+IdMM IDF+bB493tW+DnvVYRexezucpu7veq4VhxV5dY/NveajEYcYn4ojKyu1K2HQMDRrGaBceyEgrMpagB /SEvyM8OvnXd+aQQ9io8znvAgLwFajg== X-MHO-RoutePath: aGlwcGll X-MHO-User: 4b0367b5-4393-11ea-b80d-052b4a66b6b2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 4b0367b5-4393-11ea-b80d-052b4a66b6b2; Thu, 30 Jan 2020 19:04:09 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id 00UJ48GI021417; Thu, 30 Jan 2020 12:04:08 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <88fdb889b1c899412f699bb7f3abf4c6fee3aaaf.camel@freebsd.org> Subject: Re: svn commit: r357288 - head/sys/dev/usb/wlan From: Ian Lepore To: Hans Petter Selasky , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Thu, 30 Jan 2020 12:04:08 -0700 In-Reply-To: <202001300941.00U9fm6s037993@repo.freebsd.org> References: <202001300941.00U9fm6s037993@repo.freebsd.org> Content-Type: text/plain; charset="ASCII" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 487qXD12HBz4W4K X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.96 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.98)[-0.985,0]; NEURAL_HAM_LONG(-0.98)[-0.976,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jan 2020 19:04:12 -0000 On Thu, 2020-01-30 at 09:41 +0000, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Jan 30 09:41:48 2020 > New Revision: 357288 > URL: https://svnweb.freebsd.org/changeset/base/357288 > > Log: > Widen EPOCH(9) usage in USB WLAN drivers. > > This patch should unbreak the USB WLAN drivers after r357004. > > Pointy hat: glebius@ > Sponsored by: Mellanox Technologies > > Modified: > head/sys/dev/usb/wlan/if_rum.c > head/sys/dev/usb/wlan/if_run.c > head/sys/dev/usb/wlan/if_uath.c > head/sys/dev/usb/wlan/if_upgt.c > head/sys/dev/usb/wlan/if_ural.c > head/sys/dev/usb/wlan/if_urtw.c > head/sys/dev/usb/wlan/if_zyd.c > This is another piece of evidence illustratitng what a bad idea it was to try to handle network interrupts as some sort of special case in the wrong layer of the OS. Network drivers know who they are and can do the right thing. The interrupt dispatching code can only guess at what's going on by using flags that were intended for a whole other purpose. We now how multiple demonstrations of the fact that those flags cannot reliably be used as an indication of whether network packets are going to be handled during the interrupt or not. -- Ian