From owner-freebsd-bugs@FreeBSD.ORG  Wed Sep  8 05:40:21 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 83CAA16A4CF
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  8 Sep 2004 05:40:11 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E8B3243D46
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  8 Sep 2004 05:40:10 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i885eAOa038632
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 8 Sep 2004 05:40:10 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i885eAaA038631;
	Wed, 8 Sep 2004 05:40:10 GMT
	(envelope-from gnats)
Resent-Date: Wed, 8 Sep 2004 05:40:10 GMT
Resent-Message-Id: <200409080540.i885eAaA038631@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	"Jukka A. Ukkonen" <jau@iki.fi>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id DB22016A4CE
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed,  8 Sep 2004 05:37:50 +0000 (GMT)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D3D9B43D1D
	for <freebsd-gnats-submit@FreeBSD.org>;
	Wed,  8 Sep 2004 05:37:50 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.11/8.12.11) with ESMTP id i885boHG040240
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 8 Sep 2004 05:37:50 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.11/8.12.11/Submit) id i885bodQ040239;
	Wed, 8 Sep 2004 05:37:50 GMT
	(envelope-from nobody)
Message-Id: <200409080537.i885bodQ040239@www.freebsd.org>
Date: Wed, 8 Sep 2004 05:37:50 GMT
From: "Jukka A. Ukkonen" <jau@iki.fi>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-2.3
Subject: bin/71485: function list() in ipfw2 uses an uninitialized variable
	'last'
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Sep 2004 05:40:21 -0000


>Number:         71485
>Category:       bin
>Synopsis:       function list() in ipfw2 uses an uninitialized variable 'last'
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Sep 08 05:40:10 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Jukka A. Ukkonen
>Release:        4.10-STABLE
>Organization:
>Environment:
FreeBSD mjolnir 4.10-STABLE FreeBSD 4.10-STABLE #0: Sat Aug 14 11:58:59 EET DST 2004     jau@mjolnir:/home/src/sys/compile/Mjolnir  i386
>Description:
      In the function list() in ipfw2 the variable 'last' is not
initialized.
>How-To-Repeat:
      
>Fix:
Apply the following patch to ipfw2. (Tab characters have been carefully
preserved by using xcut and xclipboard to import the patch to this web
form.)

--- ipfw2.c.orig	Wed Sep  8 08:28:00 2004
+++ ipfw2.c	Wed Sep  8 08:28:07 2004
@@ -1689,7 +1689,7 @@
 	int exitval = EX_OK;
 	int lac;
 	char **lav;
-	u_long rnum, last;
+	u_long rnum, last = 0;
 	char *endptr;
 	int seen = 0;
 

>Release-Note:
>Audit-Trail:
>Unformatted: