Date: Tue, 21 Aug 2001 11:13:18 -0700 (PDT) From: Warner Losh <imp@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/pccard pcic_pci.c Message-ID: <200108211813.f7LIDJF00113@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
imp 2001/08/21 11:13:18 PDT
Modified files:
sys/pccard pcic_pci.c
Log:
It looks like we're doing the wrong thing by catching the setup_intr
request and just calling it when we get a bridge interrupt. The
problem is that if other code wants to block hardware interrupts for a
little bit with splXXX, those masks aren't updated the way we're doing
it. This doesn't matter for -current, but does for -stable.
The whole reason that we were catching interrupts was to detect that
the card was still there. Ian's fixes however ensure that the card
will be there with an interrupt handler, or not there at all. Since
the pcic interrupt is at a high priority, this should be OK.
This should fix the network related crashes people started seeing in
stable after I merged the pcic as a pci device code.
Submitted indirectly by: Ian Dowse
MFC when: Ian has had a chance to do his torture hang testing.
Revision Changes Path
1.71 +3 -42 src/sys/pccard/pcic_pci.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200108211813.f7LIDJF00113>