From owner-svn-src-all@freebsd.org Tue Dec 5 18:08:22 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F3AB1E72C98 for ; Tue, 5 Dec 2017 18:08:22 +0000 (UTC) (envelope-from erj@erj.cc) Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C1DEA65F03 for ; Tue, 5 Dec 2017 18:08:22 +0000 (UTC) (envelope-from erj@erj.cc) Received: by mail-it0-x236.google.com with SMTP id f190so3602803ita.5 for ; Tue, 05 Dec 2017 10:08:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=erj.cc; s=ericroxx; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Y8uDaEO8HXMv705m6dFVGgvtCJkhaoHe/M9ki+BMIzo=; b=Z1k7P8Cuwlh5JhXJjaLwHgHkfNF1cs4XuE/fipebUdAei7KPirmOVNNRNtYoHrvSii ohrb3b1J+g7cT5B0KhxuyKGpSyFNPIpR39BJDRWNcL1bvcQc/yPoVHiJkDtw4IEC3cw/ bCBqXxCcfCDkgLYAOHRIpoBkQfY+LxB4OIPXU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y8uDaEO8HXMv705m6dFVGgvtCJkhaoHe/M9ki+BMIzo=; b=bzi56Q/mtLLtKe+mIdJkKM99+GzLH2smtzE1UXdVWhgOWqeOl7Bh3Y0DHTzDKqLQyJ xRIL8u1XCIvn5xXbsnSBXjQVW9ahoBoC3SfnhOWtcZaSFffIvz4Ea+vChHWtU4VfKaUe NwTbupO3F4S6iceRSOG9yDYCGwVyP1S1HwadeFDkNBoXCmTi4/yw82/ZdSo73a18CHtf +NUnyJnb1tAV438+TYefI1p+2jrZBDtN4V/OOcOfaReoBRZZ/jMYTG+d74p3IDKN55Ot wvmodl9JDRe46akBJjvAZBj/xt767FXMdVRVCcoA6AA45n6xvPrWUsJseTtCJqcmhlzX VOZg== X-Gm-Message-State: AKGB3mL7fThFoxo1J0gdWLCRdKsskAAvggEznwvPeht7uFda9n+g9B0G ETC8qLTxYNi3nGNnjpgeGCeL2GWiXhvYxPcTZz3YCQ== X-Google-Smtp-Source: AGs4zMbJuBV3xdULaRI/DvC29ii9tPrdHecqP9O6NiwLsd1qorLVSvHMX0kasur1aZbB2Abjas1+f4DsqSrgxxCsdoM= X-Received: by 10.36.219.214 with SMTP id c205mr18417054itg.65.1512497301839; Tue, 05 Dec 2017 10:08:21 -0800 (PST) MIME-Version: 1.0 References: <20171205175029.64B7135B@spqr.komquats.com> In-Reply-To: <20171205175029.64B7135B@spqr.komquats.com> From: Eric Joyner Date: Tue, 05 Dec 2017 18:08:11 +0000 Message-ID: Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge usr.bin/sponge/tests usr.bin/tee To: Cy Schubert Cc: Devin Teske , Hans Petter Selasky , "rgrimes@freebsd.org" , "cem@freebsd.org" , Eitan Adler , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Dec 2017 18:08:23 -0000 I got told by a co-worker that this broke buildworld. Can this commit get reverted/have the cast fixed? - Eric (erj) On Tue, Dec 5, 2017 at 9:50 AM Cy Schubert wrote: > Our sed already creates backup files "optionally" just as gsed does. Only > the syntax is different. No need to sponge sed, just sed -i '' (whereas > gsed is -i without the argument). > > > --- > Sent using a tiny phone keyboard. > Apologies for any typos and autocorrect. > This old phone only supports top post. Apologies. > > Cy Schubert > or > The need of the many outweighs the greed of the few. > --- > ------------------------------ > From: Devin Teske > Sent: 05/12/2017 09:23 > To: Cy Schubert > Cc: Hans Petter Selasky; rgrimes@freebsd.org; cem@freebsd.org; Eitan > Adler; src-committers; svn-src-all@freebsd.org; svn-src-head@freebsd.org > > Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge > usr.bin/sponge/tests usr.bin/tee > > > On Dec 5, 2017, at 8:29 AM, Cy Schubert wrote: > > Why not update sed to create the backup file only if the suffix is given > to -i, like gnu sed does. > > > I suspect that would break countless scripts that test uname to determine > how to use the -i flag of sed. > -- > Devin > > > --- > Sent using a tiny phone keyboard. > Apologies for any typos and autocorrect. > This old phone only supports top post. Apologies. > > Cy Schubert > or > The need of the many outweighs the greed of the few. > --- > ------------------------------ > From: Devin Teske > Sent: 05/12/2017 07:35 > To: Hans Petter Selasky > Cc: rgrimes@freebsd.org; cem@freebsd.org; Eitan Adler; src-committers; > svn-src-all@freebsd.org; svn-src-head@freebsd.org > Subject: Re: svn commit: r326554 - in head: . usr.bin/sponge > usr.bin/sponge/tests usr.bin/tee > > > > On Dec 5, 2017, at 5:00 AM, Hans Petter Selasky wrote: > > > >> On 12/05/17 13:58, Rodney W. Grimes wrote: > >> Further more, why does freebsd need this in base? > > > > Hi, > > > > I think this is useful. It could replace the "-i " (intermediate) option > for "sed" for example. It avoids creating temporary files when filtering > files, right? > > > > --HPS > > > > Wth is wrong with: > > data=$( sed -e '...' somefile ) && > echo "$data" > somefile > > or > > set -e > data=... > echo "$data" > ... > > or > > exec 3< $( ... ) > EOF > cat > ... <&3 > > or > > (I digress) > > Infinite variations, but the gist is that sponge looks to be trying to > help sh(1)/similar when help is unneeded. > > Why buffer data into memory via fork-exec-pipe to sponge when you can > buffer to native namespace without pipe to sponge? > > Am I missing something? Why do we need sponge(1)? > -- > Devin > >