From owner-freebsd-fs@FreeBSD.ORG Tue Jan 18 04:52:15 2011 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 133911065674 for ; Tue, 18 Jan 2011 04:52:15 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 9E42E8FC17 for ; Tue, 18 Jan 2011 04:52:14 +0000 (UTC) Received: by wwf26 with SMTP id 26so5969096wwf.31 for ; Mon, 17 Jan 2011 20:52:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=E8zIpKyWMqv3Fp8SU02/GiBvsZQ57RUqIx0dU41mHxU=; b=o3ANDflXKIaL0rrDyEsfvrgZkXDxGcOAhNlCWMnGPS2X+3LIYupp90kpF1FRWOGPvF eeevDQ+fdBIJ+XKzLKqSdmAAJGE7hGJQxMLOoGDWAa8vrq5+MTZ3U98JIsL+AbuPgmXi NaF3165g2xBOtfTSenUeNvTRuDDGhn9P/b1z0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=R8fLTIDWEG6SyJdiqbpB3jHHREDBV0VhUFSlPVoTB4Doqc/JjhM94KnCVmV8JOlpmt P7CauVUC8lPTUupBybIRaUcXiAV577aGMKMEx1smKSM86f6l8sHRU06PNsCfcduRgi39 sfF+R1gZuJWNdzEPzqjAvCtFyCHqv1niyC6xA= MIME-Version: 1.0 Received: by 10.216.78.146 with SMTP id g18mr4240322wee.1.1295326333510; Mon, 17 Jan 2011 20:52:13 -0800 (PST) Received: by 10.216.254.226 with HTTP; Mon, 17 Jan 2011 20:52:13 -0800 (PST) In-Reply-To: <201101180116.p0I1G47e064477@chez.mckusick.com> References: <201101180116.p0I1G47e064477@chez.mckusick.com> Date: Mon, 17 Jan 2011 20:52:13 -0800 Message-ID: From: Garrett Cooper To: Kirk McKusick Content-Type: text/plain; charset=ISO-8859-1 Cc: fs@freebsd.org Subject: Re: Inconsistency and bug with *chflags functions X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jan 2011 04:52:15 -0000 On Mon, Jan 17, 2011 at 5:16 PM, Kirk McKusick wrote: > Your change looks like a step forward to me. My recommendation > is to do it. Hi Kirk! Thanks for the review! FWIW, I completely overlooked fflagstostr and strtofflags so unfortunately my patch has grown a bit (a few hundred lines). Once I have things squared away (amd64 and i386 passes make tinderbox without issues), I'll resubmit another patch just for review. Thanks! -Garrett