From owner-freebsd-current@FreeBSD.ORG  Thu Nov 24 14:49:48 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4969716A41F
	for <freebsd-current@freebsd.org>; Thu, 24 Nov 2005 14:49:48 +0000 (GMT)
	(envelope-from joseph.koshy@gmail.com)
Received: from xproxy.gmail.com (xproxy.gmail.com [66.249.82.207])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 90CDF43D66
	for <freebsd-current@freebsd.org>; Thu, 24 Nov 2005 14:49:46 +0000 (GMT)
	(envelope-from joseph.koshy@gmail.com)
Received: by xproxy.gmail.com with SMTP id s9so1395688wxc
	for <freebsd-current@freebsd.org>; Thu, 24 Nov 2005 06:49:45 -0800 (PST)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=KiEVs9GF/JviUKfBBcCPyWLouDMMWVYDD7K8+bf7XStOO1DHA4X/7bH5OoFi1lgUjdR+cDlTg1YpFVj0ykZdvIK+oUEPnKZZMIP65P1eXx3cS3pqUPP0IenuJOmmZGu+KGteLnvCxRYV1ZmydJ/iXWnSm6xcNmqKFAxBjTRcAgE=
Received: by 10.70.108.5 with SMTP id g5mr6482435wxc;
	Thu, 24 Nov 2005 06:49:45 -0800 (PST)
Received: by 10.70.105.13 with HTTP; Thu, 24 Nov 2005 06:49:45 -0800 (PST)
Message-ID: <84dead720511240649n3d3fc9c6y9010e69e937e1dfe@mail.gmail.com>
Date: Thu, 24 Nov 2005 20:19:45 +0530
From: Joseph Koshy <joseph.koshy@gmail.com>
To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
In-Reply-To: <20051121135401.GA94609@freebsd.czest.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <20051120172755.GA85641@freebsd.czest.pl>
	<84dead720511200943ua2cf8b8y49bff0dcf3e2fa63@mail.gmail.com>
	<20051120183037.GA85917@freebsd.czest.pl>
	<200511211011.29745.doconnor@gsoft.com.au>
	<20051121135401.GA94609@freebsd.czest.pl>
Cc: freebsd-current@freebsd.org
Subject: Re: [PATCH] Specifying alternative file for devd(8)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Nov 2005 14:49:48 -0000

wk> Sorry and thanks for the explanation. Updated patch:
wk>         http://freebsd.czest.pl/dunstan/FreeBSD/diff.2.devd

I've committed this patch with a few changes:

 - getopt's args and the cases in the switch statement
   were ordered alphabetically.

 - the manual page was tweaked (since I was there)

 - the following change is unnecessary.  "${name}_flags" is
   automatically used by rcNG.

   --- /usr/src/etc/rc.d/devd=09Fri Oct 28 18:55:38 2005
   +++ src/etc/rc.d/devd=09Sun Nov 20 18:15:07 2005
   @@ -13,6 +13,7 @@
    name=3D"devd"
    rcvar=3D`set_rcvar`
    command=3D"/sbin/${name}"
   +command_args=3D"${devd_flags}"

   Also, 'devd_flags' is set by the invocation of
   load_rc_config further down, so this change is
   actually a no-op.


Thank you for sending in the patch.

--
FreeBSD Volunteer,     http://people.freebsd.org/~jkoshy