From owner-freebsd-bugs@FreeBSD.ORG Wed Aug 25 21:50:29 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF5AB16A4CE for ; Wed, 25 Aug 2004 21:50:29 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id A42A043D45 for ; Wed, 25 Aug 2004 21:50:29 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i7PLoTaC028532 for ; Wed, 25 Aug 2004 21:50:29 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i7PLoTZn028531; Wed, 25 Aug 2004 21:50:29 GMT (envelope-from gnats) Date: Wed, 25 Aug 2004 21:50:29 GMT Message-Id: <200408252150.i7PLoTZn028531@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Brooks Davis Subject: Re: kern/33201: net/net_osdep.c:if_name is broken X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Brooks Davis List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2004 21:50:29 -0000 The following reply was made to PR kern/33201; it has been noted by GNATS. From: Brooks Davis To: Tilman Linneweh Cc: rwatson@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: kern/33201: net/net_osdep.c:if_name is broken Date: Wed, 25 Aug 2004 14:21:49 -0700 --5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 25, 2004 at 08:59:01PM +0000, Tilman Linneweh wrote: > Synopsis: net/net_osdep.c:if_name is broken >=20 > State-Changed-From-To: open->feedback > State-Changed-By: arved > State-Changed-When: Wed Aug 25 20:56:22 GMT 2004 > State-Changed-Why:=20 > It looks like this was resolved with the if_xname commit. > Can this PR be closed? Unless we care about fixing it in stable, we can close this. if_name() is correct other then a couple style bugs. We might want to just nuke net_osdep.c and replace if_name() with: #define if_name(ifp) ((ifp)->if_xname) This was over a year ago in NetBSD. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBLQLsXY6L6fI4GtQRAjZaAKDGLo1+78wuHYHL1Gu3xvSVDMqIeQCfUq9A RejPauD+j1Dr5su9I1M0yq0= =tlSF -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--