From owner-freebsd-bugs@FreeBSD.ORG  Sun Feb 26 18:00:29 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1165916A422
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 26 Feb 2006 18:00:29 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9F50E43D70
	for <freebsd-bugs@hub.freebsd.org>;
	Sun, 26 Feb 2006 18:00:25 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k1QI0Par085897
	for <freebsd-bugs@freefall.freebsd.org>; Sun, 26 Feb 2006 18:00:25 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k1QI0P48085896;
	Sun, 26 Feb 2006 18:00:25 GMT (envelope-from gnats)
Date: Sun, 26 Feb 2006 18:00:25 GMT
Message-Id: <200602261800.k1QI0P48085896@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Stephen Montgomery-Smith <stephen@math.missouri.edu>
Cc: 
Subject: Re: bin/93841: seg fault with dmesg
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Stephen Montgomery-Smith <stephen@math.missouri.edu>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Feb 2006 18:00:29 -0000

The following reply was made to PR bin/93841; it has been noted by GNATS.

From: Stephen Montgomery-Smith <stephen@math.missouri.edu>
To: bug-followup@FreeBSD.org,  stephen@math.missouri.edu
Cc:  
Subject: Re: bin/93841: seg fault with dmesg
Date: Sun, 26 Feb 2006 11:59:32 -0600

 And this is a slightly cleaner way to fix the problem.
 
 --- dmesg.c-orig	Sat Feb 25 16:26:18 2006
 +++ dmesg.c	Sat Feb 25 17:06:55 2006
 @@ -180,8 +180,8 @@
   		if (*p == '<') {
   			errno = 0;
   			pri = strtol(p + 1, &q, 10);
 -			if (*q == '>' && pri >= 0 && pri < INT_MAX &&
 -			    errno == 0) {
 +			if (q < nextp && *q == '>' && pri >= 0 &&
 +			    pri < INT_MAX && errno == 0) {
   				if (LOG_FAC(pri) != LOG_KERN && !all)
   					continue;
   				p = q + 1;
 
 Another possibility is to change the first if statement above to 
 something like
 
 if (p* == '<' && !isspace(*(p+1))) {
 
 but that might or might not have an undesired effect, because I don't 
 know if you mean to delete stuff like
 < 2>