From owner-svn-src-head@freebsd.org Wed Nov 8 02:06:18 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C60EE6AEC9; Wed, 8 Nov 2017 02:06:18 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-it0-x22c.google.com (mail-it0-x22c.google.com [IPv6:2607:f8b0:4001:c0b::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 549741338; Wed, 8 Nov 2017 02:06:18 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-it0-x22c.google.com with SMTP id 143so827455itf.1; Tue, 07 Nov 2017 18:06:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yKLqntQgU94Gm30Hjeuui8xMfCR76Sq0foSxKmfhnbk=; b=oPlhRN0hM8oZVX2RTx6RnMt6aRFdVox4i7XYGEcGdUSr1L95mLZoGfuJP646Fg3nrp JUpNX60MjO8y7Ae12lwy/nRbSsgWFa92huT7XE2XNURRHrJSQehFDzr4QP5eN6ShWJBI K94Rk3p5u4fn8sLL/PL8FBHfof3kiSMjoNv8E2ncsygKWEtcwN7zYvONNr73RYKwIgqP 3afJqyJyZY5YlEMTv64Zt6EHOzNYhCs7Ok5nNnM1C8iqe4YQlKQ0eHKJOwKIE7PKpyOt ObKwaHnf6QIznV9FTI510lrJU7rUdTW2Bjvz8kWFcne6in2i3F6HSz47BAwK8NT1NCP+ rrYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=yKLqntQgU94Gm30Hjeuui8xMfCR76Sq0foSxKmfhnbk=; b=pwaZ0Gx+5VKnZ4Kzoeud4V1kSY3YWrUCTAWUuL123uZOXjri0VlaRbbK1JrGrmxa+s vQ176cSyhy/5M+ksD9BzSJHIo3Lvucb+N+LTZliKiiXHjpW/RrnJ/1T73wQcXEZz5yL2 CKzG7s/gII4lAQtnP+rPOTZnrCyYA8E8QKttAURUdGTonBb96CMbM9ODlXe3Liq31wYE tK3kb9FHDz7hCOKOfMzTlAL/bH0CJPq3Q73kmnoXHcduqbLmcamlsPADiRZbiuOnlrr5 SZdZ/w/mpUc2AyMD22k77YbVxGqlOYOVPJvPi5hYsuIKFS0ExfxX86xEmc+byR0ngMNF 6M0g== X-Gm-Message-State: AJaThX5gfljIaFdreA1YT+sFqvPONzSmaQ/kmBkZyO69T0mtfrOOQWG8 recNid49NeUM++Kg9UU6kNhrWw== X-Google-Smtp-Source: ABhQp+QE1EmWLh6241RQH/lyiGTGwAz35EbOkSOZL6GOV3AcnuIVTupU7BseyxxRiijhm5rnaOBxmQ== X-Received: by 10.36.252.68 with SMTP id b65mr1680504ith.151.1510106777010; Tue, 07 Nov 2017 18:06:17 -0800 (PST) Received: from raichu (toroon0560w-lp140-01-69-159-38-22.dsl.bell.ca. [69.159.38.22]) by smtp.gmail.com with ESMTPSA id p17sm1221282iod.40.2017.11.07.18.06.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Nov 2017 18:06:16 -0800 (PST) Sender: Mark Johnston Date: Tue, 7 Nov 2017 21:06:11 -0500 From: Mark Johnston To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325528 - head/sys/vm Message-ID: <20171108020611.GA62104@raichu> References: <201711080153.vA81r3Sd092898@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201711080153.vA81r3Sd092898@repo.freebsd.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 02:06:18 -0000 On Wed, Nov 08, 2017 at 01:53:03AM +0000, Mark Johnston wrote: > Author: markj > Date: Wed Nov 8 01:53:03 2017 > New Revision: 325528 > URL: https://svnweb.freebsd.org/changeset/base/325528 > > Log: > Correct the type of foff. > > No functional change intended. Sorry for not clarifying the second sentence. vm_offset_t is 32 bits wide on some architectures, while vm_ooffset_t is always 64 bits wide. However, foff is only used when allocating a vnode pager with vm_pager_allocate(), and vnode_pager_alloc()'s "offset" parameter is unused. So the bug was real, but had no effect.