From owner-freebsd-doc  Tue Nov 21  8:46:15 2000
Delivered-To: freebsd-doc@freebsd.org
Received: from mercury.Sun.COM (mercury.Sun.COM [192.9.25.1])
	by hub.freebsd.org (Postfix) with ESMTP
	id CC80437B4CF; Tue, 21 Nov 2000 08:46:11 -0800 (PST)
Received: from sunuk.UK.Sun.COM ([129.156.85.58])
	by mercury.Sun.COM (8.9.3+Sun/8.9.3) with ESMTP id IAA22761;
	Tue, 21 Nov 2000 08:45:53 -0800 (PST)
Received: from brando.uk.sun.com (brando.UK.Sun.COM [129.156.200.30])
	by sunuk.UK.Sun.COM (8.9.3+Sun/8.9.3/ENSMAIL,v1.8) with ESMTP id QAA22316;
	Tue, 21 Nov 2000 16:39:58 GMT
Received: from uk.sun.com (localhost [127.0.0.1])
	by brando.uk.sun.com (8.9.3+Sun/8.9.3) with ESMTP id QAA10227;
	Tue, 21 Nov 2000 16:39:54 GMT
Message-ID: <3A1AA55A.18BE18E7@uk.sun.com>
Date: Tue, 21 Nov 2000 16:39:54 +0000
From: Brian Somers <brian.somers@uk.sun.com>
Organization: Sun Microsystems
X-Mailer: Mozilla 4.7 [en] (X11; I; SunOS 5.8 sun4u)
X-Accept-Language: en
MIME-Version: 1.0
To: Ben Smithurst <csxbcs@comp.leeds.ac.uk>
Cc: John Murphy <john253@crosswinds.net>, freebsd-doc@freebsd.org,
	brian@freebsd.org
Subject: Re: docs/22088: ppp filter documentation errors
References: <200011210130.RAA77762@freefall.freebsd.org> <20001121093718.A14517@comp.leeds.ac.uk>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-doc@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

I believe this was sorted out.  src/usr.sbin/ppp/defs.c:

----------------------------
revision 1.41
date: 2000/10/28 23:56:03;  author: brian;  state: Exp;  lines: +2 -2
Ignore ``#'' properly when told to
----------------------------
----------------------------
revision 1.40.2.2
date: 2000/10/28 23:56:27;  author: brian;  state: Exp;  lines: +2 -2
MFC: Ignore ``#'' properly when told to
----------------------------


Ben Smithurst wrote:
> 
> John Murphy wrote:
> 
> >  On further investigation I found that the trailing
> >  remark problem applies to any line in ppp.conf but
> >  only if there are two or more spaces or tabs before
> >  the '#' eg:
> >
> >   set speed 115200 # works
> >   set speed 115200  # fails
> >
> >  Should I submit this as a problem with ppp
> >  rather than a documentation problem?
> 
> I think so, yes. (cc'd Brian, if he can fix it straight away there might
> be no need for a PR.)
> 
> --
> Ben Smithurst / csxbcs@comp.leeds.ac.uk / ben@FreeBSD.org

--
Brian <brian.somers@uk.sun.com>


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-doc" in the body of the message