From owner-cvs-sys Mon Jun 8 02:48:37 1998 Return-Path: Received: (from daemon@localhost) by hub.freebsd.org (8.8.8/8.8.8) id CAA05622 for cvs-sys-outgoing; Mon, 8 Jun 1998 02:48:37 -0700 (PDT) (envelope-from owner-cvs-sys) Received: from sos.freebsd.dk (sos.freebsd.dk [212.242.40.180]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id CAA05611; Mon, 8 Jun 1998 02:48:30 -0700 (PDT) (envelope-from sos@sos.freebsd.dk) Received: (from sos@localhost) by sos.freebsd.dk (8.8.8/8.8.8) id LAA03144; Mon, 8 Jun 1998 11:48:23 +0200 (CEST) (envelope-from sos) Message-Id: <199806080948.LAA03144@sos.freebsd.dk> Subject: Re: cvs commit: src/sys/i386/isa/snd ad1848.c sb_dsp.c sound.c In-Reply-To: from Doug Rabson at "Jun 8, 98 10:29:57 am" To: dfr@nlsystems.com (Doug Rabson) Date: Mon, 8 Jun 1998 11:48:23 +0200 (CEST) Cc: sos@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-sys@FreeBSD.org From: Søren Schmidt Reply-to: sos@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL38 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk In reply to Doug Rabson who wrote: > On Mon, 8 Jun 1998, Sren Schmidt wrote: > > > sos 1998/06/08 02:00:29 PDT > > > > Modified files: > > sys/i386/isa/snd ad1848.c sb_dsp.c sound.c > > Log: > > Correct even more ioctl breakage :( > > Doesn't people check their code before committing anymore, it could > > at least compile ???? > > I built LINT. Perhaps these drivers should go into LINT. Not to be rude or anything, but all the mess you've created with these changes suggests to me that you didn't test this very well, you should have had these changes reviewed by someone, but the log doesn't say you did... -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- Søren Schmidt (sos@FreeBSD.org) FreeBSD Core Team Even more code to hack -- will it ever end ..