From owner-p4-projects@FreeBSD.ORG  Wed Dec 13 12:43:30 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1E18E16A508; Wed, 13 Dec 2006 12:43:30 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BC6BF16A554
	for <perforce@freebsd.org>; Wed, 13 Dec 2006 12:43:29 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 61E7243CA7
	for <perforce@freebsd.org>; Wed, 13 Dec 2006 12:41:54 +0000 (GMT)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kBDChNNF065193
	for <perforce@freebsd.org>; Wed, 13 Dec 2006 12:43:23 GMT
	(envelope-from piso@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kBDChM1S065190
	for perforce@freebsd.org; Wed, 13 Dec 2006 12:43:22 GMT
	(envelope-from piso@freebsd.org)
Date: Wed, 13 Dec 2006 12:43:22 GMT
Message-Id: <200612131243.kBDChM1S065190@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	piso@freebsd.org using -f
From: Paolo Pisati <piso@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 111629 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Dec 2006 12:43:30 -0000

http://perforce.freebsd.org/chv.cgi?CH=111629

Change 111629 by piso@piso_newluxor on 2006/12/13 12:43:14

	Comment out a check about FAST only handlers: with filters
	it shouldn't be a problem anymore.

Affected files ...

.. //depot/projects/soc2006/intr_filter/arm/at91/at91.c#6 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/arm/at91/at91.c#6 (text) ====

@@ -548,9 +548,15 @@
 {
 	struct at91_softc *sc = device_get_softc(dev);
 
-	if (rman_get_start(ires) == AT91RM92_IRQ_SYSTEM && 
-	    !IS_FAST(filter, intr))
-		panic("All system interrupt ISRs must be type INTR_FAST");
+	/*
+	 * XXX mixing FAST and non FAST handlers on arm was a pain
+	 * XXX due to latency, so this check was put here: with
+	 * XXX filters these problems should be resolved, so comment
+	 * XXX out this part but keep it here as a remainder.
+	 * if (rman_get_start(ires) == AT91RM92_IRQ_SYSTEM && 
+	 *   !IS_FAST(filter, intr))
+	 *	panic("All system interrupt ISRs must be type INTR_FAST");
+	 */
 	BUS_SETUP_INTR(device_get_parent(dev), child, ires, flags, filter, intr, 
 	    arg, cookiep);
 	bus_space_write_4(sc->sc_st, sc->sc_sys_sh, IC_IECR,