Date: Tue, 17 Mar 2020 14:11:10 +0400 From: Gleb Popov <arrowd@freebsd.org> To: Mathieu Arnold <mat@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r528542 - head/Mk/Uses Message-ID: <CALH631kq4sMZdoOUm5FKYRYbhfB0akKcccw8SpOwuObVWzX%2BJw@mail.gmail.com> In-Reply-To: <20200317073804.gosvmke23hjtphyj@atuin.in.mat.cc> References: <202003161959.02GJxRUw033181@repo.freebsd.org> <20200316200618.ogsgwf6n4sdye5ry@aching.in.mat.cc> <CALH631k64rHFOHTNTkqtTs4cNf4GR8Sjnffa5YxVE950WneDWQ@mail.gmail.com> <20200317073804.gosvmke23hjtphyj@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 17, 2020 at 11:38 AM Mathieu Arnold <mat@freebsd.org> wrote: > On Tue, Mar 17, 2020 at 10:58:50AM +0400, Gleb Popov wrote: > > On Tue, Mar 17, 2020 at 12:06 AM Mathieu Arnold <mat@freebsd.org> wrote: > > > > > On Mon, Mar 16, 2020 at 07:59:27PM +0000, Gleb Popov wrote: > > > > Author: arrowd > > > > Date: Mon Mar 16 19:59:27 2020 > > > > New Revision: 528542 > > > > URL: https://svnweb.freebsd.org/changeset/ports/528542 > > > > > > > > Log: > > > > Mk/Uses/cabal.mk: Wrap *.cabal argument in ticks. > > > > > > Why? > > > > > > > This fixed build for port I was working on. I don't have a reproducer > > anymore. > > > > Is this change bad? > > I have no idea about the change. What was bad is the commit message. A > commit message is where you record for the history WHY something was > done, so that when someone looks at it later, they can understand why it > was done. > A commit message cannot be the diff translated to english, because it > does not explain why the change was made, why it was necessary, what it > was fixing. > Acknowledged O7. I'll try my best next time . > > > > > > Modified: > > > > head/Mk/Uses/cabal.mk > > > > > > > > Modified: head/Mk/Uses/cabal.mk > > > > > > > > ============================================================================== > > > > --- head/Mk/Uses/cabal.mk Mon Mar 16 19:57:41 2020 > (r528541) > > > > +++ head/Mk/Uses/cabal.mk Mon Mar 16 19:59:27 2020 > (r528542) > > > > @@ -141,7 +141,7 @@ make-use-cabal-revs: > > > > cabal-post-extract: > > > > . for package in ${_use_cabal} > > > > . if ${package:C/[^_]*//:S/_//} != "" > > > > - cp > > > > ${DISTDIR}/${DIST_SUBDIR}/${package:C/_[0-9]+//}/revision/${package:C/[^_]*//:S/_//}.cabal > > > `find ${WRKDIR}/${package:C/_[0-9]+//} -name *.cabal -depth 1` > > > > + cp > > > > ${DISTDIR}/${DIST_SUBDIR}/${package:C/_[0-9]+//}/revision/${package:C/[^_]*//:S/_//}.cabal > > > `find ${WRKDIR}/${package:C/_[0-9]+//} -name '*.cabal' -depth 1` > > > > . endif > > > > cd ${WRKDIR} && \ > > > > mv ${package:C/_[0-9]+//} ${WRKSRC}/ > > > > > > > > > > -- > > > Mathieu Arnold > > > > > -- > Mathieu Arnold >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALH631kq4sMZdoOUm5FKYRYbhfB0akKcccw8SpOwuObVWzX%2BJw>