From owner-svn-ports-all@freebsd.org Tue Mar 17 10:11:40 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B25E3261192; Tue, 17 Mar 2020 10:11:40 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48hTV44MSpz4ZGn; Tue, 17 Mar 2020 10:11:40 +0000 (UTC) (envelope-from 6yearold@gmail.com) Received: by mail-lf1-f50.google.com with SMTP id j15so16687130lfk.6; Tue, 17 Mar 2020 03:11:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6AlBEpS08mZHcFLuBu5FbwL7b3FE5Efrz3u5fMNdn10=; b=Hdy45o4FvnAl9GPNOu5TgKi4hvgjDId+Vy6kJarkTdHcnEQGoCqhX2r36IzayVejXz Jq9ol0/+rTdbux8nWSOQ7/koNBHT6iLPrbfhxEOcWEKA/kcNVjIbX+LAFwtKBhiV9p3z Bu987i8UwUvoosYqioumFEV5FOb+PyvChqNj4opW/MPnu2EHGfL0iG2f6LcSZnQxw/Ey N8PmyXt9D/HP2hy8Uy5pC2nNcujuN3Ko37VmOsCgZZzrEKIU8WkKV211qseGuqIf28pQ ZUVpEBPcFoFbx5J/VMPjGaeV0kRHPTZY4N3lEO/AlFuH19EuXuZbBHA6MU2xQtnT147k 4fnA== X-Gm-Message-State: ANhLgQ2zNJRpcmGuvpXdr9iifZewDxyzz1eU3mZJGk9Y/jlXH7TzzeWG yH0yLRPRa7ooOuZIrjzslYXdKBtGQ+o= X-Google-Smtp-Source: ADFU+vu8ba4Ncx/051auYrtZ+7ddfD6J02SeU7Vc7+D6/OZGPiEsD6foHg2PfMmOKkoCmbGUdTZZ7Q== X-Received: by 2002:a05:6512:49e:: with SMTP id v30mr2440273lfq.158.1584439898086; Tue, 17 Mar 2020 03:11:38 -0700 (PDT) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com. [209.85.167.47]) by smtp.gmail.com with ESMTPSA id 203sm1968063ljf.65.2020.03.17.03.11.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Mar 2020 03:11:37 -0700 (PDT) Received: by mail-lf1-f47.google.com with SMTP id x143so442445lff.12; Tue, 17 Mar 2020 03:11:37 -0700 (PDT) X-Received: by 2002:ac2:5598:: with SMTP id v24mr2350450lfg.139.1584439897599; Tue, 17 Mar 2020 03:11:37 -0700 (PDT) MIME-Version: 1.0 References: <202003161959.02GJxRUw033181@repo.freebsd.org> <20200316200618.ogsgwf6n4sdye5ry@aching.in.mat.cc> <20200317073804.gosvmke23hjtphyj@atuin.in.mat.cc> In-Reply-To: <20200317073804.gosvmke23hjtphyj@atuin.in.mat.cc> From: Gleb Popov Date: Tue, 17 Mar 2020 14:11:10 +0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r528542 - head/Mk/Uses To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org X-Rspamd-Queue-Id: 48hTV44MSpz4ZGn X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.76 / 15.00]; NEURAL_HAM_MEDIUM(-0.76)[-0.760,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2020 10:11:40 -0000 On Tue, Mar 17, 2020 at 11:38 AM Mathieu Arnold wrote: > On Tue, Mar 17, 2020 at 10:58:50AM +0400, Gleb Popov wrote: > > On Tue, Mar 17, 2020 at 12:06 AM Mathieu Arnold wrote: > > > > > On Mon, Mar 16, 2020 at 07:59:27PM +0000, Gleb Popov wrote: > > > > Author: arrowd > > > > Date: Mon Mar 16 19:59:27 2020 > > > > New Revision: 528542 > > > > URL: https://svnweb.freebsd.org/changeset/ports/528542 > > > > > > > > Log: > > > > Mk/Uses/cabal.mk: Wrap *.cabal argument in ticks. > > > > > > Why? > > > > > > > This fixed build for port I was working on. I don't have a reproducer > > anymore. > > > > Is this change bad? > > I have no idea about the change. What was bad is the commit message. A > commit message is where you record for the history WHY something was > done, so that when someone looks at it later, they can understand why it > was done. > A commit message cannot be the diff translated to english, because it > does not explain why the change was made, why it was necessary, what it > was fixing. > Acknowledged O7. I'll try my best next time . > > > > > > Modified: > > > > head/Mk/Uses/cabal.mk > > > > > > > > Modified: head/Mk/Uses/cabal.mk > > > > > > > > ============================================================================== > > > > --- head/Mk/Uses/cabal.mk Mon Mar 16 19:57:41 2020 > (r528541) > > > > +++ head/Mk/Uses/cabal.mk Mon Mar 16 19:59:27 2020 > (r528542) > > > > @@ -141,7 +141,7 @@ make-use-cabal-revs: > > > > cabal-post-extract: > > > > . for package in ${_use_cabal} > > > > . if ${package:C/[^_]*//:S/_//} != "" > > > > - cp > > > > ${DISTDIR}/${DIST_SUBDIR}/${package:C/_[0-9]+//}/revision/${package:C/[^_]*//:S/_//}.cabal > > > `find ${WRKDIR}/${package:C/_[0-9]+//} -name *.cabal -depth 1` > > > > + cp > > > > ${DISTDIR}/${DIST_SUBDIR}/${package:C/_[0-9]+//}/revision/${package:C/[^_]*//:S/_//}.cabal > > > `find ${WRKDIR}/${package:C/_[0-9]+//} -name '*.cabal' -depth 1` > > > > . endif > > > > cd ${WRKDIR} && \ > > > > mv ${package:C/_[0-9]+//} ${WRKSRC}/ > > > > > > > > > > -- > > > Mathieu Arnold > > > > > -- > Mathieu Arnold >