From owner-cvs-src@FreeBSD.ORG Wed Jul 23 15:36:00 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 090DF37B401 for ; Wed, 23 Jul 2003 15:36:00 -0700 (PDT) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 9323D43FB1 for ; Wed, 23 Jul 2003 15:35:58 -0700 (PDT) (envelope-from nate@rootlabs.com) Received: (qmail 40356 invoked by uid 1000); 23 Jul 2003 22:35:59 -0000 Date: Wed, 23 Jul 2003 15:35:59 -0700 (PDT) From: Nate Lawson To: Mike Makonnen In-Reply-To: <20030723220418.GA62833@kokeb.ambesa.net> Message-ID: <20030723153526.O40342@root.org> References: <200307232029.h6NKTDHP031126@repoman.freebsd.org> <20030723220418.GA62833@kokeb.ambesa.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Peter Wemm Subject: Re: cvs commit: src/sys/kern kern_umtx.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2003 22:36:00 -0000 On Wed, 23 Jul 2003, Mike Makonnen wrote: > On Wed, Jul 23, 2003 at 01:29:13PM -0700, Peter Wemm wrote: > > peter 2003/07/23 13:29:13 PDT > > sys/kern kern_umtx.c > > Log: > > Initialize 'blocked' to NULL. I think this was a real problem, but I > > am not sure about that. The lack of -Werror and the inline noise hid > > this for a while. > > No, I don't think it was a problem. It does get initialized before > use in the same if.. statement it is compared in: > > uq = umtx_lookup(td, umtx); > if (uq == NULL || > (uq != NULL && (blocked = TAILQ_FIRST(&uq->uq_tdq)) != NULL && > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > It might be against style, though. That isn't an initialization, that's assignment. -Nate