From owner-freebsd-current@FreeBSD.ORG  Tue Oct 25 21:45:54 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 89C031065700;
	Tue, 25 Oct 2011 21:45:54 +0000 (UTC)
	(envelope-from crodr001@gmail.com)
Received: from mail-qy0-f175.google.com (mail-qy0-f175.google.com
	[209.85.216.175])
	by mx1.freebsd.org (Postfix) with ESMTP id 266728FC13;
	Tue, 25 Oct 2011 21:45:53 +0000 (UTC)
Received: by qyk35 with SMTP id 35so4526465qyk.13
	for <multiple recipients>; Tue, 25 Oct 2011 14:45:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=+V7UiJQQdFs3PB7nnmFMzBkWVqsxNladiLpxms11aFo=;
	b=M2/pvnDQe4MeV2xcD03eF3tvLkzyigmI0uTX2cZuZ7l2FkitWJyFMlueWlr3g9z+HM
	InS63LfQMKCiEm0wOdJOHT7xcfeidKJGfn7PyCKGWmHzWyWZr6494+EURIegaDn7cqTe
	Lbv5wpVts9r6aTbMqH/BuGXKBenvqRS7md7FQ=
MIME-Version: 1.0
Received: by 10.229.218.201 with SMTP id hr9mr6084039qcb.226.1319579153360;
	Tue, 25 Oct 2011 14:45:53 -0700 (PDT)
Sender: crodr001@gmail.com
Received: by 10.229.250.12 with HTTP; Tue, 25 Oct 2011 14:45:53 -0700 (PDT)
In-Reply-To: <4EA721F2.3010804@FreeBSD.org>
References: <20111020114844.GK59810@albert.catwhisker.org>
	<20111020122121.GL59810@albert.catwhisker.org>
	<201110211636.05917.jhb@freebsd.org>
	<20111025140000.GA8559@albert.catwhisker.org>
	<CAG=rPVdS+POJqATw7kmb0+b9byp3r2Vp8o=ELRFj9K7rA1zpYA@mail.gmail.com>
	<4EA71713.3020404@FreeBSD.org>
	<CAG=rPVcABO=L7Wnzb_8nDb7367CQ6j8PyF-sHC4ra4TfJQ4paQ@mail.gmail.com>
	<4EA721F2.3010804@FreeBSD.org>
Date: Tue, 25 Oct 2011 14:45:53 -0700
X-Google-Sender-Auth: 8c1p1n3kGsOqvI_R7cBnH7z4C5E
Message-ID: <CAG=rPVcNsK0Q8GbJPZbFv7W9QoWP2+=Bgp1EFnZg6sJyQXNbzw@mail.gmail.com>
From: Craig Rodrigues <rodrigc@crodrigues.org>
To: Doug Barton <dougb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-current@freebsd.org
Subject: Re: sys/conf/newvers.sh vs. subversion-1.7
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 25 Oct 2011 21:45:54 -0000

On Tue, Oct 25, 2011 at 1:54 PM, Doug Barton
> Actually hex would still work since 0x.... would match. :)

Yes, but if in the future, a revision number format is ever chosen
that doesn't include
0x at the beginning, and is something like:
a23728ea7d592acc69b36875a482cdf3fd5c8d

then this check would fail.  However, none of this
exists yet in SVN, so it is not worth worry about
right now.

It would have been nice if svnversion had
a different return status in non-SVN directories.
Checking svnversion output is fine, but
it looks like a lot of things are changing around
in SVN-land, including the output of commands.

-- 
Craig Rodrigues
rodrigc@crodrigues.org